Repository navigation
Waive cluster bus port protection for servers that support it - #572
Itzikvaknin wants to merge 1 commit into
Conversation
|
🤖 Automated first-pass review. A human maintainer still needs to review this before merge. This is a well-scoped fix, and the description explains the failure well, especially the point that the fatal error goes to stdout and leaves an empty logfile. I checked that the waiver is added before the
Nothing above changes the approach. This looks like the right fix, and with a test or two I'd be happy to see it land. I'd leave this as a comment rather than approve or request changes. |
e9ea499 to
5ca46a9
Compare
Redis now refuses to start a cluster node with tls-cluster disabled unless cluster-bus-port-protected-mode is explicitly set to no. No benchmark sets tls-cluster, so every remote oss-cluster run failed at startup with only a ping timeout to show for it. - Servers that predate the config abort on it as an unknown directive, so the remote spin-up greps the binary the DB host will run for the config name and only passes --cluster-bus-port-protected-mode no when it is there. - The waiver goes ahead of configuration-parameters: redis-server keeps the last value of a repeated option, so a benchmark's explicit setting still wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5ca46a9 to
a5c8316
Compare
Since redis/redis#15722, Redis refuses to start a cluster node with
tls-clusteroff unlesscluster-bus-port-protected-modeis explicitlyno. redisbench-admin never setstls-cluster, so every remote oss-cluster run against a recent Redis dies at startup. The only symptom is a ping timeout ("No Redis connections available"), because the fatal error goes to stdout and the logfile stays empty.This adds the waiver to the remote cluster node arguments, only for servers that know the config (as redis/redis-benchmarks-specification#570 does). Servers older than the config abort on it as an unknown directive.
--redis-server-binarycopy) for the config name.configuration-parameters. redis-server keeps the last value of a repeated option, so an explicitcluster-bus-port-protected-modestill wins.run-localclusters are unchanged.Testing
559d143b: a cluster node without the waiver fails withFATAL CONFIG FILE ERROR; with it, the node starts. Repeating the option keeps the last value.5037e19c) aborts on the waiver withUnresolved Configuration(s) Detected.559d143bbinary, 1 on the older one, and 2 when the binary is missing.🤖 Generated with Claude Code