Repository navigation
fix(install): upgrade marketplace plugins that are already installed (FIRE-2097) #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amos-qualifire
wants to merge
4
commits into
main
Choose a base branch
from
amos/fire-2097-plugin-auto-update-never-upgrades-the-installed-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2fe2096
fix(install): upgrade marketplace plugins that are already installed …
amos-qualifire 6a6a62d
fix(install): fail loudly when updating an installed plugin fails (FI…
amos-qualifire 5185078
fix(install): stop when plugin list fails, warn that a stale marketpl…
amos-qualifire 11e72e7
fix(install.ps1): run plugin CLIs under Continue so stderr cannot fai…
amos-qualifire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| #!/usr/bin/env pwsh | ||
| $here = Split-Path -Parent $MyInvocation.MyCommand.Path | ||
| $installer = [System.IO.Path]::Combine($here, '..', 'install.ps1') | ||
|
|
||
| $work = Join-Path ([System.IO.Path]::GetTempPath()) ("rogue-plugin-upgrade-" + [System.IO.Path]::GetRandomFileName()) | ||
| $bin = Join-Path $work 'bin' | ||
| New-Item -ItemType Directory -Path $bin -Force | Out-Null | ||
| $prevPath = $env:PATH | ||
| $prevProfile = $env:USERPROFILE | ||
| $env:USERPROFILE = $work | ||
| $env:FAKE_CLI_STATE = $work | ||
|
|
||
| $fakeCli = Join-Path $bin 'fake-plugin-cli-fixture.ps1' | ||
| @' | ||
| param([Parameter(ValueFromRemainingArguments = $true)][string[]]$Argv) | ||
| $snapshot = Join-Path $env:FAKE_CLI_STATE 'marketplace-snapshot' | ||
| $installed = Join-Path $env:FAKE_CLI_STATE 'installed-version' | ||
| $installedSlug = Join-Path $env:FAKE_CLI_STATE 'installed-slug' | ||
| Add-Content -LiteralPath (Join-Path $env:FAKE_CLI_STATE 'cli.log') -Value ($Argv -join ' ') | ||
| [Console]::Error.WriteLine('notice: the fake plugin CLI writes to stderr on every call') | ||
| $command = ($Argv | Select-Object -First 3) -join ' ' | ||
| if ($command -eq 'plugin marketplace add') { | ||
| if (-not (Test-Path -LiteralPath $snapshot)) { [System.IO.File]::WriteAllText($snapshot, $env:PUBLISHED_VERSION) } | ||
| exit 0 | ||
| } | ||
| if ($command -eq 'plugin marketplace update') { | ||
| [System.IO.File]::WriteAllText($snapshot, $env:PUBLISHED_VERSION) | ||
| exit 0 | ||
| } | ||
| $sub = "$($Argv[0]) $($Argv[1])" | ||
| if ($sub -eq 'plugin list') { | ||
| if ($env:FAKE_LIST_BROKEN) { exit 1 } | ||
| if (Test-Path -LiteralPath $installedSlug) { Get-Content -LiteralPath $installedSlug } | ||
| exit 0 | ||
| } | ||
| if ($sub -eq 'plugin install') { | ||
| if (Test-Path -LiteralPath $installed) { exit 0 } | ||
| Copy-Item -LiteralPath $snapshot -Destination $installed | ||
| [System.IO.File]::WriteAllText($installedSlug, $Argv[2]) | ||
| } | ||
| if ($sub -eq 'plugin update') { | ||
| if (-not (Test-Path -LiteralPath $installed)) { exit 1 } | ||
| Copy-Item -LiteralPath $snapshot -Destination $installed -Force | ||
| } | ||
| exit 0 | ||
| '@ | Set-Content -LiteralPath $fakeCli -Encoding UTF8 | ||
| if ($env:OS -eq 'Windows_NT') { | ||
| [System.IO.File]::WriteAllText((Join-Path $bin 'fake-plugin-cli.cmd'), | ||
| "@echo off`r`npowershell.exe -NoProfile -File `"$fakeCli`" %*`r`nexit /b %errorlevel%`r`n") | ||
| } else { | ||
| $shim = Join-Path $bin 'fake-plugin-cli' | ||
| [System.IO.File]::WriteAllText($shim, "#!/bin/sh`nexec pwsh -NoProfile -File `"$fakeCli`" `"`$@`"`n") | ||
| & chmod +x $shim | ||
| } | ||
| $env:PATH = $bin + [System.IO.Path]::PathSeparator + $env:PATH | ||
|
|
||
| $env:ROGUE_PLUGIN_REPO = 'rogue-test/rogue-plugins' | ||
| $env:ROGUE_INSTALL_LIB_ONLY = '1' | ||
| . $installer | ||
| $env:ROGUE_INSTALL_LIB_ONLY = $null | ||
|
|
||
| $fails = 0 | ||
| $count = 0 | ||
| function Assert-Eq { | ||
| param($Got, $Expected, [string]$Label) | ||
| $script:count++ | ||
| if ([string]$Got -ceq [string]$Expected) { Write-Host " ok: $Label" } | ||
| else { Write-Host "FAIL [$Label]: got <$Got>, expected <$Expected>"; $script:fails++ } | ||
| } | ||
| $installedFile = Join-Path $work 'installed-version' | ||
| $logFile = Join-Path $work 'cli.log' | ||
| function Get-InstalledVersion { [System.IO.File]::ReadAllText($installedFile) } | ||
| function Get-CliCalls { @(Get-Content -LiteralPath $logFile) -join ' | ' } | ||
|
|
||
| function Install-FromMarketplace { | ||
| Remove-Item -LiteralPath $logFile -ErrorAction SilentlyContinue | ||
| Add-AndRefreshMarketplace -Cli 'fake-plugin-cli' -RefreshCommand 'update' -Marketplace 'rogue-marketplace' | ||
| Update-OrInstallPlugin -Cli 'fake-plugin-cli' -PluginSlug 'rogue@rogue-marketplace' | ||
| } | ||
|
|
||
| $env:PUBLISHED_VERSION = '1.0.0' | ||
| Install-FromMarketplace | ||
| Assert-Eq (Get-InstalledVersion) '1.0.0' 'fresh: the published version is installed' | ||
| Assert-Eq (Get-CliCalls) 'plugin marketplace add rogue-test/rogue-plugins | plugin marketplace update rogue-marketplace | plugin list | plugin install rogue@rogue-marketplace' 'fresh: marketplace added and refreshed, plugin installed' | ||
|
|
||
| $env:PUBLISHED_VERSION = '1.0.1' | ||
| Install-FromMarketplace | ||
| Assert-Eq (Get-InstalledVersion) '1.0.1' 'upgrade: the installed version moves to the newly published version' | ||
| Assert-Eq (Get-CliCalls) 'plugin marketplace add rogue-test/rogue-plugins | plugin marketplace update rogue-marketplace | plugin list | plugin update rogue@rogue-marketplace' 'upgrade: marketplace refreshed, installed plugin updated' | ||
|
|
||
| $env:FAKE_LIST_BROKEN = '1' | ||
| $powershell = (Get-Process -Id $PID).Path | ||
| $failedListing = & $powershell -NoProfile -Command "`$env:ROGUE_INSTALL_LIB_ONLY = '1'; . '$installer'; Update-OrInstallPlugin -Cli 'fake-plugin-cli' -PluginSlug 'rogue@rogue-marketplace'" 2>&1 | Out-String | ||
| $failedListingExit = $LASTEXITCODE | ||
| $env:FAKE_LIST_BROKEN = $null | ||
| Assert-Eq $failedListingExit 1 'failed listing: the installer stops' | ||
| Assert-Eq (Get-InstalledVersion) '1.0.1' 'failed listing: the installed version is unchanged' | ||
| Assert-Eq ($failedListing.Contains("Run 'fake-plugin-cli plugin list' to see the error")) $true 'failed listing: the error names the list command' | ||
| Assert-Eq ($failedListing.Contains('Plugin installed')) $false 'failed listing: no success is reported' | ||
|
|
||
| $env:PATH = $prevPath | ||
| $env:USERPROFILE = $prevProfile | ||
| $env:FAKE_CLI_STATE = $null | ||
| $env:PUBLISHED_VERSION = $null | ||
| $env:ROGUE_PLUGIN_REPO = $null | ||
| Remove-Item -Recurse -Force $work -ErrorAction SilentlyContinue | ||
|
|
||
| Write-Host "" | ||
| if ($fails -eq 0) { Write-Host "test_install_plugin_upgrade_ps1: all $count passed"; exit 0 } | ||
| Write-Host "test_install_plugin_upgrade_ps1: $fails of $count failed" | ||
| exit 1 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.