Preserve CTest target identity in JUnit results - #1002
Open
Quchaosheng wants to merge 2 commits into
Open
Quchaosheng wants to merge 2 commits into
Quchaosheng wants to merge 2 commits into
Conversation
Signed-off-by: 渠超胜 <quchaosheng000406@163.com>
Signed-off-by: 渠超胜 <quchaosheng000406@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass the unique CTest target name from
add_launch_test()to the JUnit serializer and prefix each generatedtestcase.classnamewith it. This keeps distinct generated or parameterized launch tests from collapsing into the same Jenkins test history.Fixes ros2/ros2#1855
Related to osrf/buildfarm-tools#262
Testing
colcon buildforlaunch_testingandlaunch_testing_ament_cmakecolcon test: 99launch_testingtests passedcolcon test: 2launch_testing_ament_cmaketests passedtestcase.classnameGenerative AI
Codex was used to investigate the issue, implement the change, and run the tests.