Conversation
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The original check for if a file is executable fails on windows because windows doesn't consider python files as executable. Pure python packages using setup.py generate .exe's but cmake packages only copy .py files.
This is paired with
ros2/launch#1010
to actually make the python file execute correctly.
Fixes # (issue)
Is this user-facing behavior change?
Did you use Generative AI?
The edit was suggested by chatGPT after looking at what ros2run did differently.
Additional Information
The alternative much worse solution is to edit the environment variable windows uses to list executable file types, but handling python directly here is better.
set PATHEXT=%PATHEXT%;.PY