Conversation
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Signed-off-by: Griffin Tabor <tabor473@gmail.com>
Author
|
The PR ros2/launch_ros#577 replaces the need for the environment variable. Launch_ros PR lets the python file get past the initial check. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ros2 run does a check on windows for python files. They need to be executed through the python interpreter rather than directly from the system execute process call. (If the python files were "installed" through cmake)
Here we copy the logic over to launch. This solves
Is this user-facing behavior change?
Windows won't crash anymore.
Did you use Generative AI?
The edit was suggested by chatGPT looking at the error traceback and the ros2 run source code.
Additional Information
Even getting to this point requires setting an environment variable
set PATHEXT=%PATHEXT%;.PY
Because there is a check for "is executable" that looks at a hard coded list of file extensions that windows knows how to execute.