builder: only pass scrape-examples for html builds - #3438
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
Member
Author
This comment was marked as outdated.
This comment was marked as outdated.
GuillaumeGomez
approved these changes
Aug 11, 2026
Member
|
Looks good to me, thanks! |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partially a regression from #3430.
When a crate has examples, and we tried to generate the coverage, we'll get multiple json files. We don't want coverage for examples.
The actual issue seems to be that we added
-Zrustdoc-scrape-examplesto all builds, but we only want this for the html build.This is the related sentry error, I'll re-run builds for all the crates where rustdoc json failed in the last days. This will also fix coverage for these.