Repository navigation
test(instance): cover security-group create output format - #6158
ousamabenyounes wants to merge 2 commits into
Conversation
elwinar
left a comment
There was a problem hiding this comment.
At the moment, I'm not sure this is something we want to change. This is not strictly a bug as we don't have a convention in place on this (a quick look at the various golden files makes it obvious), so we're probably not going to change the format and break compatibility. The additional test is welcomed tho, if you want to re-submit without the fix that is something I'll be willing to approve.
1b3a267 to
d77ccc1
Compare
|
Updated in d77ccc1: removed the JSON unwrapping entirely and kept only regression coverage for the existing wrapped |
|
Follow-up pushed in c348a7a: deduplicated the shared security-group create command after independent review. The targeted test passes; full local CI remains iso-baseline, and Claude/OCR review passes. GitHub CI requires maintainer approval to run. |
f661cad to
b54fa38
Compare
|
I've finally taken the time to review here, can you please sign your commits before we can merge? Also of note, I've rebased your branch to get the latest changes in workflows. |
What
Adds integration coverage for the current scw instance security-group create -o json response contract:
Why
The proposed unwrapping was removed after review because changing the JSON shape would break compatibility. This PR now only locks the existing behavior with regression coverage.
Validation