Include verbatim third-party license notices - #7
Merged
neuromechanist merged 2 commits intoJul 19, 2026
Conversation
MIT, ISC, and the Boost Software License require the copyright and permission notice to accompany redistributed copies. The components were named in LICENSE and README but several notices were not shipped. - Add THIRD-PARTY-NOTICES.md with verbatim texts (liblsl MIT, asio BSL, Catch2 BSL, pugixml MIT, Loguru, libsodium ISC), assembled from the upstream files rather than transcribed - liblsl/LICENSE stated the proprietary terms over MIT-derived code and omitted the upstream notice; it now reproduces the original MIT license and scopes the proprietary grant to the additions and the integrated work - asio headers referenced an accompanying LICENSE_1_0.txt that was not present; added it - LICENSE: state that incorporated components remain under their own terms and point to the notices file - README: link the notices file Wording is legal-adjacent and should be confirmed with UCSD OIC. Closes #6
5 tasks
This was referenced Jul 19, 2026
neuromechanist
deleted the
6-include-verbatim-third-party-license-notices
branch
July 19, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
What changed
MIT, ISC, and the Boost Software License each require that the copyright and permission notice accompany redistributed copies. The incorporated components were correctly named in
LICENSEandREADME.md, but several of the notices themselves were not shipped.THIRD-PARTY-NOTICES.md(new): verbatim notices for liblsl (MIT), asio (BSL 1.0), Catch2 (BSL 1.0), pugixml (MIT), Loguru (public domain), and libsodium (ISC, external dependency, noted for binary distributions). Texts were assembled from the actual files in the tree and from upstream liblsl, not transcribed by hand.liblsl/LICENSE: previously stated only the Secure LSL proprietary terms and asserted they governed "all code in this directory, including both modifications and original components". It now reproduces the original MIT notice (Copyright (C) 2012 Christian A. Kothe) and scopes the proprietary grant to the Secure LSL additions and the integrated work, without purporting to alter the terms under which the upstream code was released.liblsl/thirdparty/asio/LICENSE_1_0.txt(new): asio's source headers say "See accompanying file LICENSE_1_0.txt", but no such file existed in the vendored copy, so the reference was broken.LICENSE: adds a carve-out stating incorporated components remain under their own licenses, and points to the notices file.README.md: links the notices file.What did not change
The licensing model itself. Academic non-profit use, the commercial license requirement, and the patent position are untouched. This is a notice-compliance and scoping change.
Why it matters beyond compliance
This is a prerequisite for bringing LabRecorder, SigVisualizer, and other client applications into this repository as component directories. With per-component notices preserved and the root carve-out in place, vendoring code that carries its own upstream license no longer places it inside a scope that reads as wholly proprietary.
Note
Wording here is legal-adjacent. Recommend confirming the final text with UCSD OIC before merge.