Expose datasets as pt.ds in addition to pt.dt - #1103
Merged
Merged
Conversation
`ds` reads as "datasets" whereas `dt` was easily mistaken for "data" or "datetime". The dataset module is now exposed as both `pt.ds` and `pt.dt`, with all docstrings, tests and docs switched to `pt.ds`. `pt.dt` keeps working unchanged and without a deprecation warning, so no user code breaks. The prek mypy hook cannot spawn `mypy` in this checkout, so mypy was run separately against the project interpreter and passes.
Pulls in scverse/pertpy-tutorials#75 (the `pt.dt` -> `pt.ds` rename) and scverse/pertpy-tutorials#73 (the signature reversal section).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
+ Coverage 79.94% 79.97% +0.02%
==========================================
Files 55 55
Lines 7533 7534 +1
==========================================
+ Hits 6022 6025 +3
+ Misses 1511 1509 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1100.
The dataset module is now available as both
pt.dsandpt.dt, and all docstrings, tests and docs usept.ds.pt.dtkeeps working as an undeprecated alias, so existing user code is unaffected.