Repository navigation
fix: drop wrapper frames from schedule stacks when schedule is overridden - #25
Merged
Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
schedule is overridden
This was referenced Oct 5, 2026
sderrow
marked this pull request as ready for review
October 5, 2026 02:22
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Schedule-location stacks now start at the caller even when a limiter overrides
schedule()with a subclass method (includingasync) or an arrow function on the instance. Previously, the override's wrapper frames appeared at the top of every section.If the override isn't on the stack, for example when the base method is called directly, a fallback capture keeps the section intact. Overrides made with
.bind()keep their wrapper frames, because V8 can't cut a stack at a bound function.The schedule-stack code also moves out of
async-context.tsinto its ownschedule-stack.tsmodule, with its tests in a matching file. That move doesn't change behaviour.