Repository navigation
fix: flaky Group error and timing test - #28
Merged
Merged
Conversation
This was referenced Oct 5, 2026
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sderrow
marked this pull request as ready for review
October 5, 2026 02:58
sderrow
changed the title
sderrow
changed the title
sderrow
changed the title
sderrow
changed the base branch from
sean/enable-more-lint-rules
to
graphite-base/28
October 5, 2026 03:07
"Should pass error on failure" asserted an exact cross-key interleaving ([6] before [3]) that only held if a 40ms setTimeout fired inside a 100ms minTime window. Under the redis projects the Group is still local but timers are real, so an event-loop stall reordered the keys and failed the test. Assert the contract instead: hold key A's first job with a deferred, then show B's failure reaches its caller and C runs both jobs while A is held, so keys don't share capacity, minTime, or failures. A then drains in order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sderrow
force-pushed
the
sean/fix-group-error-flake
branch
from
October 5, 2026 03:11
2d03b46 to
2356669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky test fix. In a real redis situation, we can only assert the contract instead of exact timing: hold key A's first job with a deferred, then show B's failure reaches its caller and C runs both jobs while A is held, so keys don't share capacity, minTime, or failures. A then drains in order.