Repository navigation
Remove Yandex.Metrika support - #18
Merged
Merged
Conversation
Drop the Metrika counter and goal-tracking scripts from default.html, the data-ym-goal attributes from the print button and the contact and social links in cv.html, and the yandex_metrika examples from the README and the demo config. The data-goatcounter-click hooks stay on every link, and Google Analytics is untouched. A site that still sets yandex_metrika keeps building. Jekyll ignores the unknown key, and the tag simply stops loading once the site updates the theme.
impuls42
changed the title
Merged
impuls42
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Yandex.Metrika integration from the theme.
default.html: the Metrika counter in<head>and the goal-tracking script before</body>are gone.cv.html:data-ym-goalis gone from the print button and the nine contact and social links. Theirdata-goatcounter-clickhooks stay._config.demo.ymlno longer show ayandex_metrikaexample.A site that still sets
yandex_metrikakeeps building. Jekyll ignores the unknown key, and the tag stops loading once the site updates the theme. alex-cv doesn't set it.Checked by building the demo in a ruby:3.4.9 container with
yandex_metrika,goatcounterandgoogle_analyticsall set. On main the page loads mc.yandex.ru and has 10data-ym-goalattributes. On this branch nothing Yandex is left in the output, and the GoatCounter script, its 10 click hooks, the GA tag and the print button are all still there.Release prep landed separately in #19 (this PR merged before that commit reached it).