Repository navigation
fix: 辞書の入力制限を共有し、補助漢字を正しい文字数で保存 - #35
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APIが受け付ける補助漢字80文字を、画面では40文字までしか入力できない問題を修正します。Refs #19
生成した規則を入力検査、単語追加の可否、件数・上限の説明に使います。API型とUnicode case foldingの生成を維持し、生成結果の一致検査も辞書の上限を対象にします。API・上限値・保存形式は変更しません。
入力中の検査とAPIの検証は、それぞれ画面の下書きと外部からの要求を守るために残します。認識・AI要求の辞書取得、手修正と公開、取消の既存の担当も維持し、責務をARCHITECTURE.mdへ記録しました。
Evidence
After: 80文字を保存でき、81文字はAPIを呼ばず、下書きとエラーを保持します。
bash scripts/check.sh成功。ローカルのフロントエンド143件、バックエンド195件、生成契約の一致、型検査、ビルドが成功しました。Merge Danger
Door: two-way
Blast Radius: dictionary
生成ファイルの参照先をアプリ内部で更新しています。frontendはprivate packageで、HTTPのAPI形式は維持します。ルーム名とトークの背景にも同じHTML制限が残るため、次の計画に分けて続けます。#19はその確認まで開いておきます。
投稿セッション:合成音声でGemini・GPT動作確認