Repository navigation
refactor(mothership): keep a queued send's reused id in one field - #8746
Merged
Merged
Conversation
resumeUserMessageId is the only id a queue entry goes out under; the Stop handoff seed no longer carries a copy and reusedRequestId is gone. The stored handoff record keeps its userMessageId and is converted where it enters and leaves the queue. Queues saved with the id on the seed move it to resumeUserMessageId on rehydrate.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
6 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifth step of the chat send-queue consolidation (after #8744). A queued send's reused request id now lives in one field. No behaviour change.
resumeUserMessageIdis the only id a queue entry goes out under. Before, the Stop-handoff seed (QueuedSendHandoffSeed.userMessageId) carried a copy that was always equal to it. The seed drops that copy, andreusedRequestIdgoes away. These now readresumeUserMessageIddirectly:needsResendCheck/resendVerdict;startSendMessagepicks.QueuedSendHandoffState) keeps itsuserMessageId, as the transport record. It is converted at the two points where it meets the queue:resumeUserMessageId;resumeUserMessageId; if the entry already had one, that one wins. The copy is dropped from the seed, and the admission guard then applies to the entry as before.replaceAtno longer needs to clear a seed id when an entry is edited.Type of Change
Testing
store.dom.test.tstest,moves the reused id a saved Stop handoff carried onto the entry. It covers an entry saved with the id only on its seed, and one saved as never sent. It fails on staging.resumeUserMessageId. What they test is unchanged.Checklist