Repository navigation
feat(biometrics): let the HR estimator report nothing instead of a weak-signal guess - #840
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ng
force-pushed
the
feat/biometrics-local-fit
branch
from
October 18, 2026 01:18
4d3359c to
8319f8b
Compare
ng
force-pushed
the
feat/hr-estimator-guard
branch
from
October 18, 2026 01:21
1e3d2f7 to
8dfef8b
Compare
Contributor
Author
|
CodeRabbit (mirror ng#25) findings, addressed in 8dfef8b:
Rebased onto the updated #837. |
… can report nothing instead of a weak-signal guess
…rops weak-signal heart-rate guesses
…ying and translate the beat-score control
ng
force-pushed
the
feat/hr-estimator-guard
branch
from
October 18, 2026 01:53
8dfef8b to
54ea17c
Compare
ng
enabled auto-merge
October 18, 2026 01:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The local runner (#837) showed that tuning the heart-rate tracker can't bring pod HR in line with the Apple Watch.
Across the 8 nights with Watch HR (10-08 to 10-16, 526 paired readings):
Cause. I logged the subharmonic-summation candidates on night 10-14. In 15 of 18 big misses, the Watch's true rate was not a candidate at all: the autocorrelation had a single peak between 45 and 120 bpm, at the wrong rate (Watch 52, pod 62–65). The tracker passed 95 of 98 misses straight through, because its consistency rule accepts jumps of up to about 1.55× the tolerance.
What
heart_rate.minimumPeakScore, range 0.1–0.8, shipped default 0.4. It replaces the hard-coded 0.1 floor insubharmonic_summation_hr. Windows scoring below it report no heart rate instead of a guess, which changes default output on weak-signal windows for every pod. A profile can set 0.1 to restore the old behaviour.sourceHashesentry forsignal.py. The calibration card gets a slider row for the parameter, and i18n catalogs are re-extracted.--min-coverage(default 75%) of the defaults' Watch coverage. The old common-support statistic scores any abstaining change as exactly 0.000, so it couldn't see this change.--save-readingsfor error analysis.Evidence (local replay of the real code through the pod's evaluator; equal-night means)
Deploy note
The manifest hash changes. Existing profile revisions pin the old manifest, so after deploying, those revisions (including the left side's active one) report
PROFILE_INCOMPATIBLE: pinned engine is not available in this buildand must be re-proposed against the new manifest. This is the existing versioning contract; no migration is added here.Test plan
pytest modules/common(419) andmodules/piezo-processor(204), plus new tests: abstention below the threshold, unchanged default, range validationupdateDeployand the waveform publication integration test, both pass alonetsc --noEmit, eslint🤖 Generated with Claude Code
🛏️ Beam this PR onto a sleepypod ✨
Pick the snippet that matches your pod. Already-installed pods can't use the curl bootstraps below — sleepypod's egress firewall DROPs github.com, and the script that knows how to unblock WAN is the very file curl is trying to fetch. Use
sp-updateinstead; it's on disk and opens WAN as its first step.🔄 Already on a sleepypod (most common — review a PR on a running pod):
🚀 Fresh pod / first install — bootstraps from GitHub, rebuilds every push:
curl -fsSL https://raw.githubusercontent.com/sleepypod/core/feat/hr-estimator-guard/scripts/install \ | sudo bash -s -- --branch feat/hr-estimator-guard🎯 Pin to this exact build (run 39088122122 ·
54ea17c) — fresh-pod path, locked to one CI artifact for reproducible review:🧊 Artifact:
sleepypod-core· self-destructs in 30 days 💥