Repository navigation
fix(cli): CLI contract follow-ups (exit codes, stdout purity, scope validation, redaction, config errors) - #1496
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
98b71d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67425b9d.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-b5-cli.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37302977289 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI contract hardening: exit codes, stdout purity, scope validation, sensitive data redaction, and config error handling.
Fixed Items
mcpproxy disconnect <client>validates scope rules before attempting disconnectSkipped Items
None identified as unresolved in this batch.
Open Findings (Not Addressed)
disconnectof an unregistered client now exits 1 (previously 0). This is a breaking change when a client has no config file, no servers section, or no mcpproxy entry.Refs #1451
Refs #1435
Refs #1466
Refs #1394