Skip to content

fix(cli): CLI contract follow-ups (exit codes, stdout purity, scope validation, redaction, config errors) - #1496

Merged
Dumbris merged 2 commits into
mainfrom
fix/issues-b5-cli
Oct 5, 2026
Merged

Dumbris merged 2 commits into
mainfrom
fix/issues-b5-cli

Conversation

@Dumbris

@Dumbris Dumbris commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

CLI contract hardening: exit codes, stdout purity, scope validation, sensitive data redaction, and config error handling.

Fixed Items

  • 1451-8: Confirmation prompt (disconnect/remove) routed to stderr to preserve stdout purity for JSON output mode
  • 1435-1: mcpproxy disconnect <client> validates scope rules before attempting disconnect
  • 1466-2: Config validation errors caught during import; file-not-found and parse errors reported upfront
  • 1394-1: Sensitive data redaction in tool args logged to activity (e.g., cloud credentials, API keys, file paths)

Skipped Items

None identified as unresolved in this batch.

Open Findings (Not Addressed)

  • glm:1.F1 (medium): disconnect of an unregistered client now exits 1 (previously 0). This is a breaking change when a client has no config file, no servers section, or no mcpproxy entry.
  • glm:1.F2 (low): The 1451-8 test injects its own writer into readConfirmation. If confirmYes is changed back to direct readConfirmation(os.Stdin, os.Stdout, prompt), tests still pass but stdout is polluted by the confirmation prompt in JSON mode.

Refs #1451
Refs #1435
Refs #1466
Refs #1394

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98b71d3
Status: ✅  Deploy successful!
Preview URL: https://67425b9d.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-issues-b5-cli.mcpproxy-docs.pages.dev

View logs

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: fix/issues-b5-cli

Available Artifacts

  • archive-darwin-amd64 (31 MB)
  • archive-darwin-arm64 (28 MB)
  • archive-linux-amd64 (19 MB)
  • archive-linux-arm64 (17 MB)
  • archive-windows-amd64 (31 MB)
  • archive-windows-arm64 (27 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (27 MB)
  • installer-dmg-darwin-arm64 (24 MB)
  • smart-mcp-proxymcpproxy-go9CJJ82.dockerbuild (0 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 37302977289 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/mcpproxy/daemon_rest.go 75.00% 1 Missing ⚠️
internal/config/loader.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants