Skip to content

fix(httpapi,runtime): API correctness follow-ups (404 logs, empty scope param, import preview, telemetry lock, changed-fields audit) - #1505

Merged
Dumbris merged 3 commits into
mainfrom
fix/issues-b7-backend-httpapi
Oct 5, 2026
Merged

Dumbris merged 3 commits into
mainfrom
fix/issues-b7-backend-httpapi

Conversation

@Dumbris

@Dumbris Dumbris commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

API correctness follow-ups: fix 404 logging, empty scope validation, import preview state, telemetry lock semantics, and changed-fields audit trail for config patches.

Fixes

Open Finding

  • F1.1 (medium, not addressed): EnablePrompts and Instructions added to hot-field list but are read-only at server construction. PATCH requests with these fields now report applied_immediately:true, requires_restart:false, yet running servers keep boot-time values. Fix requires moving both fields to restart-gated (add to pinRestartGated, report requires_restart:true). This is deferred to a follow-up to avoid scope creep.

Refs #1466
Refs #1394
Refs #1435

…1435)

- logs: unknown server returns 404 via contracts.ErrServerNotFound (#1466)
- scope filters: present-but-empty ?token=/?client=/?profile= is rejected like a valued one (#1394)
- telemetry lock: refuse case-variant duplicate telemetry sections while locked (#1466)
- hot reload: report every top-level config field in ChangedFields instead of 'No configuration changes detected'; startup-bound ones are restart-gated and pinned (#1435)
@Dumbris
Dumbris enabled auto-merge (squash) October 5, 2026 12:46
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b53632
Status: ✅  Deploy successful!
Preview URL: https://7e6d5bfd.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-issues-b7-backend-httpap.mcpproxy-docs.pages.dev

View logs

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/httpapi/server.go 71.42% 1 Missing and 1 partial ⚠️
internal/runtime/config_hotreload.go 89.47% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit e023d9f into main Oct 5, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants