Repository navigation
fix(web): Spec 109 UI lows (Activity blocked offer, Home flash, health tile, onboarding/import counts, telemetry refresh, logs 404, sessions e2e) - #1506
Merged
Conversation
Dumbris
enabled auto-merge (squash)
October 5, 2026 12:47
Deploying mcpproxy-docs with
|
| Latest commit: |
58796da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e788222e.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-b10-frontend.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Dumbris
added a commit
that referenced
this pull request
Oct 6, 2026
…port names (#1516) ## Summary Frontend fixes for the Clients presence store, the admin-key upgrade dialog, the access explainer fix routes and the import completion event. - 1451-10 (approved: last_seen and active_sessions come from the 30s presence poll): `frontend/src/stores/clients.ts` lets the poll own presence; a change drops stale detail presence fields and reloads the detail. Test: `clients-store-presence.spec.ts`. - 1451-4 (approved: clear the clients filter only when it would hide the target): `useScopeQuery.ts` clientDetail route clears the filter conditionally. Test: `client-binding-controls.spec.ts`. - 1446-1 (approved: clear wording): `UpgradeAdminKeyDialog.vue` partial failure states what succeeded and failed, withholds the rotate panel and offers Try again; rotate only when next_step is set. Test: `client-binding-controls.spec.ts`. - 1446-10 (approved: scope on every fix route except move_client): `AccessExplainer.vue` routes go through the scope link map. Test: `access-explainer.spec.ts`. - #1506 follow-up: `ImportServers.vue` emits only the names the core actually imported. Test: `import-servers-completion.spec.ts`. - Docs: `docs/features/connect-clients.md` wording. Skipped: none of the assigned items for this batch. Other wave-2 items (1435-5, 1466-8, 1466-24, 1465-4) are in other batches. ## Review Status Clean after 1 round(s). Unresolved findings: glm:1.1 (low, low-deferred) - a stale loadDetail response can overwrite a newer poll result and re-mark the row detail-loaded, regressing last_seen/active_sessions for up to one poll cycle; the unguarded `void loadDetail(id)` fired by refreshPresence has no staleness check. Refs #1446 Refs #1451 Refs #1466
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses UI issues in Spec 109 implementation:
Fixes
Open Findings
Refs #1466
Refs #1451