Repository navigation
fix(httpapi): empty import preview on paste/upload and stale-classification save warnings - #1529
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
7389e77
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://084165db.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w5b4-internal-htt.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37444336139 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the empty-import preview on paste/upload and adds stale-classification warnings when saving a profile.
{}returned 400 on the upload and paste handlers. Root cause: format detection rejected{}as unknown. Change: anisEmptyJSONObjectearly return in preview mode returns a 200 with an empty preview (emptyImportPreview). Test: new cases ininternal/httpapi/import_test.gofor upload and paste.internal/runtime/profiles_service.gonow emits warnings for stale classify entries on save; docs indocs/features/profiles.mdandspecs/108-profiles-v3/contracts/rest-api.mdupdated. Test:internal/runtime/profiles_service_test.go.Skipped / deferred
/servers/import/path?preview=truewith a bare{}and no format hint still returns 400 "unable to detect configuration format". Pre-existing behaviour on a sibling endpoint outside the named handlers.{}content in preview mode now returns 200 empty instead of 400 (the early return runs before hint validation). Low impact.Review Status
Clean after 2 round(s). Unresolved findings, both low and deferred:
{}with no format hint previews as 200-empty on upload and paste, but/servers/import/pathstill returns 400. Pre-existing path-handler behaviour; sibling-endpoint inconsistency only.isEmptyJSONObjectearly return runs before format-hint validation, so{"content":"{}","format":"bogus"}withpreview=truereturns 200 empty instead of 400.Closes #1446
Refs #1466