Skip to content

build: harden the release build scripts - #76

Merged
sfc-gh-vpalekar merged 1 commit into
snowflakedb:mainfrom
sfc-gh-eukim:release-build-hygiene
Sep 15, 2026
Merged

sfc-gh-vpalekar merged 1 commit into
snowflakedb:mainfrom
sfc-gh-eukim:release-build-hygiene

Conversation

@sfc-gh-eukim

@sfc-gh-eukim sfc-gh-eukim commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refine the release build setup so artifacts are built only from
committed sources:

  • build.sh / pypi-build.sh refuse to build unless the git checkout is
    pristine (no modified, untracked, or ignored files); for local test
    builds, SNOWFLAKE_TELEMETRY_ALLOW_DIRTY_WORKSPACE=1 bypasses the check
  • record the full HEAD commit in the conda build instead of the short
    hash
  • write a SHA256SUMS manifest of the build artifacts for downstream
    verification
  • anaconda/build.sh runs setup.py in isolated mode (-I)

Operational note

The first Jenkins run after merge will stop if the workspace has any
leftover files (the error message lists them); enable clean checkout or
wipe the workspace first.

@snowflake-security-bot snowflake-security-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

Comment thread anaconda/meta.yaml Outdated
Comment thread tests/test_release_build_hygiene.py Outdated
Comment thread scripts/release_lib.sh
Refine the release build setup:

- refuse to build unless the git checkout is pristine (no modified,
  untracked, or ignored files), so release artifacts contain only
  committed sources; SNOWFLAKE_TELEMETRY_ALLOW_DIRTY_WORKSPACE=1
  bypasses the check for local test builds
- record the full HEAD commit in the conda build instead of the short
  hash
- write a SHA256SUMS manifest of the build artifacts for downstream
  verification
- run setup.py in isolated mode (-I) in the conda build

Co-authored-by: Cursor <cursoragent@cursor.com>
@sfc-gh-vpalekar
sfc-gh-vpalekar merged commit 3a21196 into snowflakedb:main Sep 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants