Bump numpy from 2.2.6 to 2.5.3 - #207
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [numpy](https://github.com/numpy/numpy) from 2.2.6 to 2.5.3. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v2.2.6...v2.5.3) --- updated-dependencies: - dependency-name: numpy dependency-version: 2.5.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
villelaitila
left a comment
There was a problem hiding this comment.
Reviewed this dependency bump (numpy 2.2.6 → 2.5.3). The diff itself is a single-line version pin change, but it surfaces one real compatibility concern flagged inline: NumPy 2.5.x has dropped support for Python 3.8-3.11, while this project's setup.cfg still declares support down to Python 3.8. Since numpy is a direct import (src/sgraph/cypher.py) and there's no CI matrix testing across the declared Python versions, this would only surface as an install failure for anyone still on Python 3.8-3.11. No other logical issues found in the diff.
Generated by Claude Code
| @@ -1,4 +1,4 @@ | |||
| numpy==2.2.6 | |||
| numpy==2.5.3 | |||
There was a problem hiding this comment.
Potential Python-version compatibility gap introduced by this bump: NumPy 2.5.3's own release notes state "This release supports Python versions 3.12-3.15," i.e. it drops wheels/support for 3.8-3.11. This repo's setup.cfg still declares python_requires = >=3.8 and lists classifiers for Python 3.8-3.13.
numpy is a direct import in src/sgraph/cypher.py (not merely a transitive dependency of pandas), and it's pinned here as a plain (non-optional) dev/test requirement — unlike spycy-aneeshdurg, which is explicitly commented as optional. So pip install -r requirements.txt would fail outright on Python 3.8-3.11, even though the package still advertises support for those versions.
Since there's no CI matrix in this repo running the test suite across the declared Python versions, this gap wouldn't be caught automatically before merge. Worth either verifying nothing here still needs to run on 3.8-3.11, or holding this bump (or pinning an intermediate numpy version) until the supported-version floor is reconciled.
Generated by Claude Code
Bumps numpy from 2.2.6 to 2.5.3.
Release notes
Sourced from numpy's releases.
... (truncated)
Changelog
Sourced from numpy's changelog.
... (truncated)
Commits
dd88c0cMerge pull request #32511 from charris/prepare-2.5.3edcac6aREL: Prepare for the NumPy 2.5.3 releasefd4d908Merge pull request #32509 from charris/backport-3249665bb1daBUG: fix crash in ufunc.resolve_dtypes with a Python scalar type (#32496)294956eMerge pull request #32506 from charris/backport-3250326428d9DOC: fix scipy docs links in intersphinx mapping (#32507)5fab1cbDOC: use static scipy doc site for intershpinx (#32503)7beed2fMerge pull request #32481 from ngoldbaum/stringdtype-backport8972f70Merge pull request #32478 from charris/backport-32466ab1b589Merge pull request #32477 from charris/backport-32423Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)