Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential Python-version compatibility gap introduced by this bump: NumPy 2.5.3's own release notes state "This release supports Python versions 3.12-3.15," i.e. it drops wheels/support for 3.8-3.11. This repo's
setup.cfgstill declarespython_requires = >=3.8and lists classifiers for Python 3.8-3.13.numpyis a direct import insrc/sgraph/cypher.py(not merely a transitive dependency of pandas), and it's pinned here as a plain (non-optional) dev/test requirement — unlikespycy-aneeshdurg, which is explicitly commented as optional. Sopip install -r requirements.txtwould fail outright on Python 3.8-3.11, even though the package still advertises support for those versions.Since there's no CI matrix in this repo running the test suite across the declared Python versions, this gap wouldn't be caught automatically before merge. Worth either verifying nothing here still needs to run on 3.8-3.11, or holding this bump (or pinning an intermediate numpy version) until the supported-version floor is reconciled.
Generated by Claude Code