Repository navigation
Prefer release initiator for docs ownership - #1311
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ChrisJBurns
approved these changes
Nov 3, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Duplicate initiator trailers and mixed-case bot logins can incorrectly bypass ownership fallbacks in the release-docs workflow.
2 open issues
What changed in this PR
This PR updates release-docs ownership routing to prefer the release initiator over the person who merged the upstream release PR.
Changes:
- Reads
Release-Triggered-Byfrom the tagged commit, including squash-merge messages with blank lines between trailers. - Preserves release author, release PR merger, and commit author fallbacks.
- Adds workflow tests for tag types, unusable metadata, and fallback behavior.
| File | Description |
|---|---|
scripts/upstream-release/workflow.test.mjs |
Adds owner-resolution fixtures and regression tests. |
.github/workflows/upstream-release-docs.yml |
Prioritizes initiator metadata and reuses tagged commit data for fallback resolution. |
Review effort: Balanced
Comment on lines
+560
to
+561
| INITIATOR=$(printf '%s\n' "$COMMIT_MESSAGE" \ | ||
| | sed -n 's/^Release-Triggered-By:[[:blank:]]*//p') |
| | sed -n 's/^Release-Triggered-By:[[:blank:]]*//p') | ||
| # Accept a single GitHub login. Missing, malformed, duplicate, | ||
| # or bot trailers fall through to the existing owner sources. | ||
| if [[ "$INITIATOR" =~ ^[a-zA-Z0-9]([a-zA-Z0-9-]{0,37}[a-zA-Z0-9])?$ ]] && ! is_bot "$INITIATOR"; then |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release-docs ownership currently falls to the upstream release PR's merger when a bot publishes the release. With a separate reviewer typically merging the release PR, this can assign ownership to someone who did not initiate the release.
Prefer the human initiator recorded in the tagged commit's
Release-Triggered-Bytrailer. Preserve the existing human release author, release PR merger, and tagged commit author fallbacks. Accept the squash-merge format that separates the initiator trailer fromCo-authored-bywith a blank line, and fall back for missing, malformed, duplicate, or bot initiators.Validation: 19 release-docs helper tests and 12 reviewer-routing tests pass, along with focused Prettier, ESLint, and
git diff --check. A read-only execution of the updated workflow step against ToolHive v0.60.0 resolvesjhrozek. The production site build passes. Local actionlint reports the existing$/.github/actions/setupaction alias, which it does not recognize.Type of change
Related issues/PRs
Submitter checklist
Content and formatting
Reviewer checklist
Content