Repository navigation
Handle source pointer objects in move location helpers - #237
Merged
stefankoegl merged 1 commit intoOct 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix follows existing pointer-handling behavior, and the regression tests cover the reported failures with no unresolved issues.
No open issues 🎉
What changed in this PR
Fixes MoveOperation source-location helpers so they accept JsonPointer objects consistently with apply().
Changes:
- Reuses
_from_pointer()when reading or updating source-location parts. - Adds regressions for standard and custom pointer classes, including applying a move after editing its source.
| File | Description |
|---|---|
| tests.py | Adds pointer-object regression tests for source-location helpers. |
| jsonpatch.py | Uses existing pointer handling in three source-location helpers. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoveOperationaccepts aJsonPointerobject infrom, but its public source-location helpers try to parse that object as a string. Readingfrom_pathorfrom_key, or changing the source withset_from_part(), therefore raisesTypeErroreven though the operation can be applied.Reuse
_from_pointer()in those three places, asapply()already does. Added regressions for plain and custom pointer classes, including editing the source and applying the resulting move.Validation:
git diff --checkpass.