Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jsonpatch.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def apply(self, obj):

@property
def from_path(self):
from_ptr = self.pointer_cls(self.operation['from'])
from_ptr = self._from_pointer()
return '/'.join(from_ptr.parts[:-1])

@property
Expand All @@ -396,14 +396,14 @@ def from_key(self, value):
self.set_from_part(-1, value)

def get_from_part(self, index):
from_ptr = self.pointer_cls(self.operation['from'])
from_ptr = self._from_pointer()
try:
return int(from_ptr.parts[index])
except ValueError:
return from_ptr.parts[index]

def set_from_part(self, index, value):
from_ptr = self.pointer_cls(self.operation['from'])
from_ptr = self._from_pointer()
from_ptr.parts[index] = str(value)
self.operation['from'] = from_ptr.path

Expand Down
28 changes: 28 additions & 0 deletions tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -1676,6 +1676,34 @@ def test_set_from_key(self):
self.assertEqual(operation, {'op': 'move', 'from': '/c~1d/0', 'path': '/b'})
self.assertEqual(op.apply({'c/d': ['x']}), {'c/d': [], 'b': 'x'})

def test_from_path_with_pointer_object(self):
for pointer_cls in (jsonpointer.JsonPointer, CustomJsonPointer):
with self.subTest(pointer_cls=pointer_cls):
op = jsonpatch.MoveOperation(
{'op': 'move', 'from': pointer_cls('/a/1/b'), 'path': '/c'},
pointer_cls=pointer_cls)
self.assertEqual(op.from_path, 'a/1')

def test_from_parts_with_pointer_object(self):
for pointer_cls in (jsonpointer.JsonPointer, CustomJsonPointer):
with self.subTest(pointer_cls=pointer_cls):
op = jsonpatch.MoveOperation(
{'op': 'move', 'from': pointer_cls('/a/1/b'), 'path': '/c'},
pointer_cls=pointer_cls)
self.assertEqual(op.from_key, 'b')
self.assertEqual(op.get_from_part(1), 1)

def test_set_from_key_with_pointer_object(self):
for pointer_cls in (jsonpointer.JsonPointer, CustomJsonPointer):
with self.subTest(pointer_cls=pointer_cls):
operation = {'op': 'move', 'from': pointer_cls('/a/1'),
'path': '/b'}
op = jsonpatch.MoveOperation(operation, pointer_cls=pointer_cls)
op.from_key = 0
self.assertEqual(operation['from'], '/a/0')
self.assertEqual(op.apply({'a': ['x', 'y']}),
{'a': ['y'], 'b': 'x'})


class CustomJsonPointer(jsonpointer.JsonPointer):
pass
Expand Down
Loading