Repository navigation
Fix bpm-tray .app: pin MACOSX_DEPLOYMENT_TARGET - #11
Merged
Merged
Conversation
Real bug found live: without MACOSX_DEPLOYMENT_TARGET set, the macos-latest CI runner's cgo linker embedded whatever its own SDK defaults to (observed: minos 26.0) into bpm-tray's LC_BUILD_VERSION load command. The binary itself still ran fine from a terminal (a direct exec doesn't check this), but open/LaunchServices enforces it against the running OS, so the packaged .app silently refused to launch on any real Mac not yet on that OS version - exactly the Finder/Spotlight/Launchpad path this whole feature exists for. Pinned to 11.0, matching Info.plist.template's LSMinimumSystemVersion. Verified locally: rebuilt with the pin, otool -l now shows minos 11.0, and a freshly assembled .app opens correctly via `open`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real bug found live: unset MACOSX_DEPLOYMENT_TARGET meant the CI runner's cgo linker embedded minos 26.0 into the binary. Ran fine from a terminal (exec doesn't check this) but open/LaunchServices refused to launch the .app on any real machine below that OS version - defeating the whole Finder/Spotlight point. Pinned to 11.0. Verified with otool -l and a real open.