Skip to content

Fix bpm-tray .app: pin MACOSX_DEPLOYMENT_TARGET #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syscod3 merged 1 commit into from
Aug 2, 2026
Merged

Fix bpm-tray .app: pin MACOSX_DEPLOYMENT_TARGET #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,20 @@ jobs:
# .tar.gz filename is versioned) so the Homebrew formula's
# `bin.install "bpm-tray"` finds it - matches how goreleaser's own
# archives contain a plain "bpm", not "bpm_vX_os_arch".
#
# MACOSX_DEPLOYMENT_TARGET matters here: real bug found live - left
# unset, the macos-latest runner's cgo linker embeds whatever its
# own SDK defaults to (observed: minos 26.0) into the binary's
# LC_BUILD_VERSION load command. `open`/LaunchServices enforces
# that against the *running* OS - unlike a direct exec, which
# ignores it - so the resulting .app failed to launch via Finder/
# Spotlight on any real Mac not yet running that OS version, while
# still running fine from a terminal. Pinned to 11.0 to match
# Info.plist.template's LSMinimumSystemVersion.
for arch in arm64 amd64; do
dir="dist-tray/darwin_${arch}"
mkdir -p "$dir"
CGO_ENABLED=1 GOARCH=$arch go build -o "$dir/bpm-tray" ./cmd/bpm-tray
MACOSX_DEPLOYMENT_TARGET=11.0 CGO_ENABLED=1 GOARCH=$arch go build -o "$dir/bpm-tray" ./cmd/bpm-tray
tar -C "$dir" -czf "dist-tray/bpm-tray_${{ github.ref_name }}_darwin_${arch}.tar.gz" bpm-tray
done
- name: Build AppIcon.icns from the embedded logo
Expand Down
Loading