Repository navigation
Fix bpm-tray release archive binary name - #8
Merged
Merged
Conversation
Real bug found integrating the Homebrew formula: the tray tarball's internal binary was named bpm-tray_vX_darwin_arch (matching the archive's own filename), not plain bpm-tray, so Formula bin.install "bpm-tray" failed with ENOENT on real brew install. goreleaser's own bpm archives don't have this problem because its archive template only versions the .tar.gz filename, not the binary inside. Fixed by building into a per-arch staging dir and tarring from inside it, so only the .tar.gz filename is versioned. Verified locally: tar -tzf now lists a bare bpm-tray entry. Also restructured the README's Getting Started to lead with three actual run methods (Homebrew, Docker, from-source-as-fallback) and folded the menu bar app into the Homebrew section, since brew install now installs bpm-tray too on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real bug found integrating the Homebrew formula: tray tarball's internal binary was versioned (bpm-tray_vX_darwin_arch), not plain bpm-tray, so 'bin.install "bpm-tray"' failed with ENOENT on a real brew install. Fixed. Also restructured README's Getting Started into three actual run methods (Homebrew/Docker/from-source-fallback), folding the menu bar app into the Homebrew section since it's now installed alongside bpm on macOS.