Repository navigation
test: disable system alerts only if option exists - #553
Merged
patapenka-alexey merged 1 commit intoAug 27, 2026
Merged
patapenka-alexey merged 1 commit into
patapenka-alexey merged 1 commit into
Conversation
This was referenced Aug 26, 2026
patapenka-alexey
approved these changes
Aug 26, 2026
patapenka-alexey
left a comment
patapenka-alexey
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch!
Totktonada
commented
Aug 26, 2026
Totktonada
commented
Aug 26, 2026
Totktonada
force-pushed
the
disable-system-alerts-only-if-option-exists
branch
from
August 26, 2026 15:47
a873282 to
97d06c9
Compare
Contributor
Author
|
@patapenka-alexey, @bigbes, @elhimov, I've updated the patch a bit to handle tarantool 2.x and early 3.x versions seamlessly. Please, take a look. |
elhimov
reviewed
Aug 27, 2026
bigbes
approved these changes
Aug 27, 2026
Contributor
|
Please, rebase your branch against the updated master. |
This commit reimplements version-based check from PR tarantool#549 with a direct check of whether the given option (`config.checks`) exists. It gives a valid configuration for any tarantool 3.x version, including intermediate developer builds. The motivation is that integration testing with metrics `master` fails in tarantool's CI, because the `config.checks` config option does not exist at the moment. While the feature that adds the option is under some discussion, let's just fix the CI. Follows up PR tarantool#549 Related to tarantool/tarantool#12371
Totktonada
force-pushed
the
disable-system-alerts-only-if-option-exists
branch
from
August 27, 2026 10:09
97d06c9 to
5873c03
Compare
Contributor
Author
|
Rebased on top of a fresh |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reimplements version-based check from PR #549 with a direct check of whether the given option (
config.checks) exists. It gives a valid configuration for any tarantool 3.x version, including intermediate developer builds.The motivation is that integration testing with metrics
masterfails in tarantool's CI, because theconfig.checksconfig option does not exist at the moment. While the feature that adds the option is under some discussion, let's just fix the CI.Follows up PR #549
Related to tarantool/tarantool#12371