Repository navigation
fix(branching): root-only --branch; JSON envelopes for saved-filter branch failures - #177
Merged
thomaschristory merged 2 commits intoOct 22, 2026
Merged
Conversation
…r branch failures - --branch after the subcommand is left to that command (e.g. a plugin's branch filter) instead of switching the invocation into a branch (#170). - A BranchError while resolving --saved filters now emits the envelope in the requested output format instead of the catch-all table (#173). Claude-Session: https://claude.ai/code/session_01NfmMN4S8UFCdVCVrnMkjGH
This was referenced Oct 22, 2026
…command Found by adversarial review of #177: `nsc --branch x profiles list` was not recognised as a meta command and bootstrapped the schema. Claude-Session: https://claude.ai/code/session_01NfmMN4S8UFCdVCVrnMkjGH
Owner
Author
|
Adversarial review: no critical/important findings; both fixes verified to fail without the change. Applied: |
thomaschristory
deleted the
fix/branching-flag-and-saved-filter-errors
branch
October 22, 2026 19:12
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_extract_global_overridesscanned the whole argv, so--branchafter the subcommand (for example the Branching plugin's ownchanges list --branchfilter) switched the whole invocation into that branch.--branchis now taken as global only before the first subcommand. Other global flags (-o,--profile, …) keep scanning anywhere, as before.BranchErrorraised while resolving--savedfilters (outside the handler's try) fell through tomain()'s catch-all, which always renders TABLE. It is now caught at the call site and emitted withmap_error, using the requested-oformat and includingdetails.branch.--branchgoes before the subcommand. CHANGELOG has Unreleased → Fixed entries.Test plan
test_branch_after_subcommand_is_not_globalandtest_saved_filter_branch_failure_honours_json_outputfailed before the fix and pass after it--branchbefore the subcommand plus-oafter it still both applyjust lint; full suite 1552 passedCloses #170
Closes #173
https://claude.ai/code/session_01NfmMN4S8UFCdVCVrnMkjGH