Repository navigation
Conversation
The status bar shared its "Reading" with the Reading tab in Options, so a translator had to pick a word that works for both, and most languages chose one that reads oddly next to a percentage. "Progress" is the word the Document Info sheet on iOS already uses for the same number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status bar reads "Line 5, Character 120, Reading 45%". Its "Reading" is the same msgid as the
Reading tab in Options, so each language has a single translation for both, and most of them chose
the name of the activity, which fits the tab but not the number: Hungarian "Olvasás 45%", Spanish
"Leyendo 45%", German "Lesen 45%", Russian "Чтения 45%". Translators can't fix it on their side,
because the catalog has no context to tell the two apart.
This changes the status bar label to "Progress", so it reads "Line 5, Character 120, Progress 45%".
That's already a msgid: the Document Info sheet on iOS labels the same percentage "Progress", so
most languages have a translation for it, and the status bar and iOS now use the same word. The
Reading tab keeps its name. I've updated the Windows UI test that waits for the status bar text.
I came across this while reviewing the Hungarian translation. If you'd rather keep "Reading" in
English, the alternative would be a message context for one of the two, but as far as I can see
the catalog doesn't use
msgctxtanywhere yet.Tested on:
cargo test --workspace, and the UI tests the Windows CI jobruns with
--ignored, including the updatedstatus_bartest, pass.cargo test --workspacepasses exceptmacos_menu_shortcuts, whichfails on my machine with or without this change, because of my Hungarian keyboard layout.
cargo +nightly fmt --all --checkis clean, and Clippy adds no warnings in the changed files.🤖 Generated with Claude Code