Skip to content

Label the status bar percentage "Progress" rather than "Reading" #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tormazs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Label the status bar percentage "Progress" rather than "Reading" #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/paperback/src/ui/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ use wxdragon::prelude::*;
use super::{document_manager::DocumentManager, navigation};

pub fn format_status_text(info: &StatusInfo) -> String {
// TRANSLATORS: Status bar label for the current line number, e.g. "Line 5, Character 120, Reading 45%"
// TRANSLATORS: Status bar label for the current line number, e.g. "Line 5, Character 120, Progress 45%"
let line_label = t("Line");
// TRANSLATORS: Status bar label for the current character offset within the line
let char_label = t("Character");
// TRANSLATORS: Status bar label for the reading progress percentage, e.g. "Line 5, Character 120, Reading 45%"
let reading_label = t("Reading");
// TRANSLATORS: Status bar label for how far through the document the reader has got, e.g. "Line 5, Character 120, Progress 45%"
let progress_label = t("Progress");
format!(
"{} {}, {} {}, {} {}%",
line_label, info.line_number, char_label, info.character_number, reading_label, info.percentage
line_label, info.line_number, char_label, info.character_number, progress_label, info.percentage
)
}

Expand Down
2 changes: 1 addition & 1 deletion crates/paperback/tests/status_bar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mod common;
fn status_bar_shows_the_caret_line_from_the_moment_a_document_opens() {
let app = common::launch("status-bar");
common::wait_for_reader_focus(app.pid);
common::wait_for_status_prefix(app.pid, "Line 1, Character 1, Reading 0%");
common::wait_for_status_prefix(app.pid, "Line 1, Character 1, Progress 0%");

common::arrow_down();
common::wait_for_status_prefix(app.pid, "Line 2, ");
Expand Down
Loading