Repository navigation
test: cover RuleLogic edge cases - #25
Merged
Merged
Conversation
Author
|
The Build & Release workflow is sitting in |
anubhavaanand
force-pushed
the
test/rulelogic-edge-cases
branch
from
November 11, 2026 17:50
a1b587b to
b7d5649
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
RuleLogicedge cases requested in #23:start == end, windows ending at midnight, and23:59 -> 00:000/100, first run withprevPercent = -1, and crossing both boundary thresholdsNo production code changed, and no test exposed a production bug.
start == endcurrently covers that single minute because the window bounds are inclusive; the test has a comment documenting that behavior. All 32 unit tests pass.Target
beta(default)main(stable hotfix only)Checklist
Verification
Closes #23.