Repository navigation
Sync lgse/strata#1752–#1776: density sliders, preview scrollbar, chooser save names - #32
Merged
Merged
Conversation
…r save names Syncs upstream fd63272..4b9a6ac (lgse/strata#1752, #1786, #1792, #1794, #1796, #1776). Review loop in progress. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
…e owners Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
…plit long sentences Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G2EPXpxTkT2NMHoDUw59DX
5 tasks
…rchy variants per theme, ZIP root markers, Properties Copy path Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016cpLemtNiNbF8xyDV5PcFB
…ording, columns mirror, probes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016cpLemtNiNbF8xyDV5PcFB
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016cpLemtNiNbF8xyDV5PcFB
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016cpLemtNiNbF8xyDV5PcFB
…ndow titles, signed installer, activation GDK_DEBUG, reopen closed tabs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
…r, tabs, thumbnails Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
…taller, preview gaps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
… tabs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fazi6bx93e32CsuE8zqzMx
Sync lgse/strata#1822..#1800: Enter target, STL thumbnails, folder window titles, signed installer, activation GDK_DEBUG, reopen closed tabs
Sync lgse/strata#1771..#1816: QA scenarios replace the E2E suite, Omarchy variants per theme, ZIP root markers, Properties Copy path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Upstream range
fd6327265eaa3266f8420fe8bd25e965146344b0→4b9a6ace71017888b3a2124d7d911c5c664cc767(7 commits, 6 PRs). Watermark advanced insources.yaml.preview/preview-panelintegration/portal-file-chooserapp/infrastructureapp/infrastructure(triage → fallback)browser/view-modes/densityPer node
browser/view-modes/density— origin {issue: Add independent frame and browser/content density controls lgse/strata#1774, pr: feat(appearance): frame & browser-content density lgse/strata#1776}. Frame (0–12 px) and Content (0–16 px) sliders in the titlebar Appearance menu, and the saved-settings rules. Codesrc/ui/window/density_slider.rs; testssrc/ui/window/tests/appearance_density.rs,src/ui/theme/tests/density.rs,src/ui/preferences/tests/preferences.rs; docsdocs/preferences.md. Added tosite/unguided.yaml("New since v1.0.0…"). It describes the code, not the PR body, which is stale: the body says no menu change, Frame not applied, and a 4 px first Custom value.browser/view-modes— the radio bullet loses Compact/Airy (#1776). The DENSITY bullet moves to the new child. A new### Content densitygroup holds Content spacing, becausebrowser_modes.rsimplements it. A Design bullet on the type-group sorter cites #1791/#1792.settings/themes— new### Frame densityBehavior group, becauseframe_density_csslives intheme.rs. A Design bullet covers the density CSS provider (#1776).testsgainssrc/ui/theme/tests/density.rs. The Azure Glow fallback bullet is now sourced by #1794, so(unverified)is dropped. The Known gap "docs/themes.md names Azure Glow as the default" is removed, since #1794 fixed it.browser/directory-monitoring— listing cap 100,000 → 250,000. Behavior and Design cite #1792 (no row).preview/preview-panel/documents— new### Scrollinggroup: document-coordinate thumb, held thumb, monotonic drag, edges, momentum stop, hit testing. Also a table-drag unmap bullet, Design on the scrollbar and deferred rendered rows, and three Known gaps citing #1752. Paths added:src/ui/virtual_preview/scrollbar.rs,scrollbar/position.rs,line_numbers.rs,scrollbar/tests.rs,tests/e2e/mutations/preview-scrollbar.patch,docs/document-previews.md.integration/portal-file-chooser— Save-name click refill bullets and a Design bullet (#1785, #1786; 10xer bullet cites #1311).…/setup: the doc Known gap is removed (see "Needs a person").app/infrastructure— rows for #1794 and #1792. Design bullet on theinvariant-checksCargo feature (#1792).codegainsscripts/e2e-mutation-check.sh.reviewed_atonly: app/accessibility, browser/folder-customization, browser/scrolling, browser/selection, browser/view-modes/list (re-verified grouping against #1792's sorter; no content change), browser/view-modes/list/column-layout, integration/custom-actions, preview/preview-panel/{find,layout,model-views}, preview/quick-preview, settings/preferences/storage, settings/themes/{corner-roundness,icons,interface-font,omarchy}.QA
Sweeps touched:
app,browser,integration,preview,settings(allreviewed_at→ 4b9a6ac).### browser/view-modes/densityprobes (full-range drags, restart and second window, two windows, wheel and paging, Orca, hand-writtensettings.tomlvalues). A Content-spacing marquee probe goes under view-modes. A grouped-sort-during-200k-load probe goes under view-modes/list. A 200k/260k listing probe goes under directory-monitoring. Setup gains 200,000- and 260,000-entry folders.browser.Tier-1 plans (
qa --pr N --tier 1):Only one unmapped file remains:
data/icons/scalable/actions/strata-rows.svg, which #1776 deleted and which needs no owner.Needs a person
app/infrastructure. A reviewer argued it is a batch PR, with the sorter (view-modes) and theinvariant-checksgate inselection.rs(browser/selection). Either way, the perf PR also edits Behavior on directory-monitoring, because the cap change is a real shipped change.codeis narrow. Saved-settings behavior is implemented insrc/ui/preferences.rs(a settings sweep trigger) andDensityScaleinbrowser_modes.rs. Later persistence PRs will map to view-modes or the settings trigger, not to this node.preview/preview-panel/documents/scrollbar(origin fix(preview): rendered Markdown jumps between two positions while holding the scrollbar lgse/strata#1749 / #1752, own testsscrollbar/tests.rs, E2E scenario, mutation patch). It would promotedocuments.mdtodocuments/index.md. Not created.docs/portal-file-chooser.mdlines 73–76 and 88 still describe a first-launch offer.take_prompt_offer_at(src/portal_setup.rs:579) is test-only, and the offer was removed in feat(settings): make System file manager also install Reveal in File Manager integration lgse/strata#947. #1794 fixed only the Settings-path half.docs/preferences.md"Content and Frame density" says Compact keeps a staticdensity-compactrule instyle.css. No such rule exists; Compact is the base style.site/src/reference/remote-sftp.md:64still says 100,000 entries.checkwarns thatsite.releaseis v1.0.0 while v1.1.0 is the latest stable tag.4b9a6ac chore: release v1.1.0(no PR).PolicyType::External). It is recorded as(unverified).(unverified)claims added:Review loop
3 rounds, 4–5 reviewers each, with verifiers on every blocking finding.
settings/themesandbrowser/view-modes.browser/view-modes/icons.md:25("Airy density adds modest padding", #747) overlaps the new view-modes Airy Icons bullet.theme.rsbehavior and could move to settings/themes.check: 0 errors, 25 warnings, all site-release staleness. Unit tests pass.Note:
data/prs.jsonlwas not committed. GraphQL is unavailable in this environment, so the six PR rows were extracted via the REST API into a scratch copy.Generated by Claude Code