Conversation
ccec8b1 to
22d2903
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #849
Scan targets checked: wolfboot-src, wolfboot-bugs
Coverage: 3 of 7 in-scope changed file(s) opened by the reviewer; not opened: include/user_settings.h, src/elf.c, src/update_flash.c, test-app/app_ti_am64x_r5.c
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #849
Scan targets checked: wolfboot-src, wolfboot-bugs
Coverage: 2 of 7 in-scope changed file(s) opened by the reviewer; not opened: include/user_settings.h, src/elf.c, src/image.c, src/update_flash.c, test-app/app_ti_am64x_r5.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Boot, flash, and crypto behavior needs hardware validation, and unresolved build issues remain.
Review effort: Balanced
Findings: 3
Open (13)
Remove unsupported TI target from CMake · New Gate SA2UL completion on receiving all input bytes · New Preserve flash lookup and erase failures · New Serialize and track SysConfig generation dependencies · New Align size reporting with scatter output selection · New Handle failed RNG initialization before RNG_read · New Serialize test-app SysConfig generation · New Check ELF_FLASH_SCATTER explicitly for value 1 · New Add squashelf prerequisite for TI test-app builds · New Track AM64x benchmark timer reset origin · New Invoke the prepared SDK component script path · New Use the correct AM64x R5 configuration · New Replace LPC55S69 flashing steps with AM64x instructions · New
What changed in this PR
This draft adds a TI AM64x Cortex-R5 port to wolfBoot, including SDK-based boot and test-app builds.
Changes:
- Adds the AM64x HAL, linker scripts, and SDK configuration.
- Adds test-app support and adjusts ELF image handling.
- Adds target documentation and build-system entries.
| File | Description |
|---|---|
| test-app/wolfcrypt_support.c | Adds AM64x timing hooks. |
| test-app/Makefile | Adds SDK sources and image packaging. |
| test-app/ARM-ti_am64x_r5.ld | Defines application memory layout. |
| test-app/app_ti_am64x_r5.c | Adds the demo application. |
| src/update_flash.c | Gates ELF diagnostic output. |
| src/image.c | Gates ELF diagnostic output. |
| src/elf.c | Gates ELF diagnostic output. |
| options.mk | Adjusts AM64x debug flags. |
| Makefile | Adds SysConfig and ROM image generation. |
| include/user_settings.h | Adds AM64x wolfCrypt settings. |
| hal/ti_am64x_r5.ld | Defines bootloader memory layout. |
| hal/ti_am64x_r5.c | Adds flash, entropy, and boot hooks. |
| docs/Targets.md | Adds AM6442 target guidance. |
| config/examples/ti-am64x-r5/ti-am64x-r5_test-app.syscfg | Configures application peripherals. |
| config/examples/ti-am64x-r5/ti-am64x-r5_hal.syscfg | Configures bootloader peripherals. |
| config/examples/ti-am64x-r5/mcuplussdk_11.02.00_sa2ul.c.patch | Patches the SDK crypto driver. |
| config/examples/ti-am64x-r5.config | Provides a target build configuration. |
| CMakeLists.txt | Lists the target for CMake. |
| arch.mk | Adds the TI toolchain and SDK objects. |
| .gitignore | Ignores generated output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.



TI AM64x port, based on the TI MCU Plus SDK 11.02, running on one of the cortex-r5's.
See wolfSSL/wolfssl#11121 for the corresponding wolfCrypt support.
Draft pull request, while I finish up a few lingering items...