TI am64x port

[twcook86]

Description

Adds support for TI am64x hardware acceleration, based on api's from the TI MCU Plus SDK.

• trng ctr-drbg
• aes-ecb-128/256
• aes-cbc-128/256
• aes-gcm-128/256
• sha256/512
• hmac-sha256/512
• cmac-aes-128/256

Testing

Tested with a new wolfBoot port and wolfssl test/benchmark code.

Corresponding wolfBoot support: wolfSSL/wolfBoot#849

Checklist

• [na] added tests
• [na] updated/added doxygen
• [tbd] updated appropriate READMEs
• Updated manual and documentation

[github-actions]

MemBrowse Memory Report

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• linuxkm-pie
• linuxkm-standard
• stm32-sim-stm32h753

[wolfSSL-Bot]

Looks like you've got some work to do.
No test results found.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11121

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 13
13 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

[philljj]

Retest this please.

(no logs)

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11121

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfssl-src, wolfssl-bugs
Coverage: 9 of 14 in-scope changed file(s) opened by the reviewer; not opened: wolfcrypt/src/aes.c, wolfcrypt/test/test.c, wolfssl/wolfcrypt/aes.h, wolfssl/wolfcrypt/port/ti/ti-sa2ul_r5_port.h, wolfssl/wolfcrypt/sha256.h

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

[Copilot]

Copilot review overview

🟡 Changes recommended

The implementation has deterministic DRBG seeding, hash-state correctness issues, and inaccurate benchmark output.

Review effort: Balanced
Findings: 3 · 6

Open (9)

• Pass a 64-bit value for the %llu total_cycles format · New
• Seed CTR-DRBG with entropy, not only the device UID · New
• Preserve SHA-256 length carry into hiLen · New
• Use countSz for benchmark block_size metadata · New
• Add timeout and error handling to RNG readiness polling · New
• Update AES encryption IV only after success · New
• Initialize SHA-256 context before teardown · New
• Initialize SHA-512 context before teardown · New
• Enable AES-GCM in the platform default configuration · New

What changed in this PR

Adds TI AM64x R5 SA2UL hardware acceleration for MCU Plus SDK and wolfBoot integrations.

Changes:

• Adds accelerated RNG, AES, SHA-2, HMAC, and CMAC support.
• Integrates initialization, crypto callbacks, configuration, tests, and benchmarks.
• Documents supported hardware features and build switches.

File	Description
.wolfssl_known_macro_extras	Registers TI port macros.
wolfssl/​wolfcrypt/​types.h	Adjusts TI compiler pragma handling.
wolfssl/​wolfcrypt/​sha512.h	Adds TI SHA-512 context state.
wolfssl/​wolfcrypt/​sha256.h	Adds TI SHA-256 context state.
wolfssl/​wolfcrypt/​settings.h	Configures AM64x features.
wolfssl/​wolfcrypt/​port/​ti/​ti-sa2ul_r5_port.h	Declares the SA2UL port API.
wolfssl/​wolfcrypt/​include.am	Distributes the port header.
wolfcrypt/​test/​test.c	Integrates TI output and device definitions.
wolfcrypt/​src/​wc_port.c	Initializes the SA2UL backend.
wolfcrypt/​src/​sha512.c	Manages TI SHA-512 contexts.
wolfcrypt/​src/​sha256.c	Manages TI SHA-256 contexts.
wolfcrypt/​src/​random.c	Integrates the TI RNG provider.
wolfcrypt/​src/​port/​ti/​ti-sa2ul_r5_port.c	Implements SA2UL acceleration.
wolfcrypt/​src/​port/​ti/​README_sa2ul.md	Documents the port.
wolfcrypt/​src/​include.am	Distributes the port source.
wolfcrypt/​src/​ecc.c	Adds the TI string compatibility include.
wolfcrypt/​src/​aes.c	Routes AES direct operations through callbacks.
wolfcrypt/​benchmark/​benchmark.c	Adds embedded and CSV benchmark support.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11121

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfssl-src, wolfssl-bugs
Coverage: 6 of 13 in-scope changed file(s) opened by the reviewer; not opened: wolfcrypt/src/aes.c, wolfcrypt/src/ecc.c, wolfcrypt/src/random.c, wolfssl/wolfcrypt/port/ti/ti-sa2ul_r5_port.h, wolfssl/wolfcrypt/settings.h, wolfssl/wolfcrypt/sha256.h, wolfssl/wolfcrypt/sha512.h

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

[Copilot]

Copilot review overview

🟡 Changes recommended

DRBG initialization, hash failure cleanup, resource lifecycle, and portable benchmark formatting have unresolved correctness issues.

Review effort: Balanced
Findings: 1

Open (1)

• Close NRBG handle before initializing the configured DRBG · New

Resolved since last review (9)

• Preserve SHA-256 length carry into hiLen
• Seed CTR-DRBG with entropy, not only the device UID
• Pass a 64-bit value for the %llu total_cycles format
• Enable AES-GCM in the platform default configuration
• Initialize SHA-512 context before teardown
• Initialize SHA-256 context before teardown
• Update AES encryption IV only after success
• Add timeout and error handling to RNG readiness polling
• Use countSz for benchmark block_size metadata

Previously missed (4)

In code that hasn't changed since last review

Cast word64 arguments for portable %llu formatting

wolfcrypt/​benchmark/​benchmark.c:3227

word64 is typedef'd as unsigned long when SIZEOF_LONG == 8 (types.h:390-400), so passing these values directly to %llu is a variadic type mismatch on LP64 targets and can produce undefined output. Cast both arguments to unsigned long long (or use a project-wide portable 64-bit format macro).

Fix variadic type mismatch in %llu conversion

wolfcrypt/​benchmark/​benchmark.c:3232

This %llu conversion also receives word64 directly; on LP64 builds word64 is unsigned long, not unsigned long long, making the variadic call undefined. Use an explicit matching cast or a portable format macro.

Release SA2UL context and mutex on hardware failure

wolfcrypt/​src/​port/​ti/​ti-sa2ul_r5_port.c:867

On a hardware-processing failure this returns while scObj still owns the SA2UL context and the global hardware mutex remains locked. Subsequent accelerated operations will therefore remain unavailable (and the context leaks) until this hash object happens to be freed. Release the context before propagating the error.

This issue also appears in the following locations of the same file:

• line 881
• line 1010
• line 1028

Add TI RNG and Crypto handle cleanup

wolfcrypt/​src/​port/​ti/​ti-sa2ul_r5_port.c:1225

The RNG and Crypto handles opened by this initializer have no matching TI cleanup hook in wolfCrypt_Cleanup(); wc_CryptoCb_Cleanup() only unregisters callbacks (cryptocb.c:545-552). A cleanup/re-init cycle therefore leaves the SDK resources open and attempts to open them again. Add a TI port cleanup that closes both handles and invoke it from the final wolfCrypt cleanup path.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #11121

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfssl-src, wolfssl-bugs
Coverage: 6 of 12 in-scope changed file(s) opened by the reviewer; not opened: wolfcrypt/src/aes.c, wolfcrypt/src/ecc.c, wolfcrypt/src/sha512.c, wolfcrypt/test/test.c, wolfssl/wolfcrypt/settings.h, wolfssl/wolfcrypt/sha512.h

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite