chore: align Rust toolchains on 1.98.1 - #437
Merged
Merged
Conversation
Dzejkop
marked this pull request as ready for review
September 16, 2026 11:09
Dzejkop
requested review from
aurel-fr,
crystalt,
karankurbur and
sideround
as code owners
September 16, 2026 11:09
paolodamico
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Bedrock's repository toolchain, CI, cargo-deny, and release workflows on Rust 1.98.1 for the shared rollout instead of mixing Rust 1.94.1 with floating stable jobs.
Retain the original upgrade's behavior-preserving Clippy fix, use fixed-size result chunks for the paymaster migration, and replace test-only constant
format!calls as required by Rust 1.98. Dependencies and runtime behavior are unchanged.Validation
cargo +1.98.1 fmt --all -- --checkcargo +1.98.1 clippy --workspace --all-targets --all-features -- -D warningsgit diff --checkThe matching Foundry integration test built but could not start because the local Foundry executable is unavailable. Full integration tests and Swift/Kotlin builds remain for CI.
Rollout dependency
Keep this PR in draft until Infrastructure #48339, WalletKit #509, Oxide #1190, Biometric Engines #648, and Flamingo #104 are ready. Version alignment will intentionally fail while the organization variable remains 1.94.1. No live variable or infrastructure change is made here.
AI usage/prompt(s)
Codex: “Adjust the coordinated Rust upgrade PRs to align on Rust 1.98.1, validate compatibility, and include Flamingo now that it participates in organization version alignment.”
Note
Low Risk
Toolchain and CI pinning plus style-level Rust fixes; no dependency or production logic changes beyond equivalent duration/chunking APIs.
Overview
Pins Bedrock to Rust 1.98.1 end-to-end:
rust-toolchain.tomlmoves from 1.94.1, and CI, cargo-deny, and release workflows stop using floatingstablein favor of the same fixed version.Small 1.98 / Clippy compatibility tweaks with no intended behavior change: Turnkey migration timeout is expressed via
Duration::from_mins(3)instead of 180 seconds; paymaster migration pairs multicall results withas_chunks::<2>()instead ofchunks_exact(2); smart-account tests compare against string literals with.to_string()rather thanformat!on constants.Reviewed by Cursor Bugbot for commit 4582a4e. Bugbot is set up for automated code reviews on this repo. Configure here.