chore: align Rust toolchains on 1.98.1 - #509
Merged
Merged
Conversation
This was referenced Sep 4, 2026
Dzejkop
marked this pull request as ready for review
September 16, 2026 11:09
Dzejkop
requested review from
Takaros999,
danielle-tfh,
kilianglas and
philsippl
as code owners
September 16, 2026 11:09
Dzejkop
added a commit
that referenced
this pull request
Sep 16, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 39198e9. Configure here.
| readme = "./README.md" | ||
| homepage = "https://docs.world.org" # TODO: Update to specific WalletKit page | ||
| rust-version = "1.91" # MSRV | ||
| rust-version = "1.94.1" # MSRV |
There was a problem hiding this comment.
MSRV raised despite 1.91 policy
Medium Severity
rust-version and the CI MSRV matrix now declare 1.94.1, which raises the published workspace minimum above the 1.91 MSRV this change set out to keep. Downstream crates on Rust 1.91 through 1.94.0 will fail the Cargo version check.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 39198e9. Configure here.
Dzejkop
added a commit
that referenced
this pull request
Sep 16, 2026
Dzejkop
force-pushed
the
codex/rust-1-97-rollout
branch
from
September 17, 2026 09:44
8a5ba2a to
65fd487
Compare
paolodamico
approved these changes
Sep 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pin WalletKit's development, CI, crate release, and Swift release compilers to Rust 1.98.1 for the shared Rust rollout. Refresh only the Nix Rust overlay so the host, WASM, and Android shells resolve this release. Preserve the declared Rust 1.91 workspace MSRV.
Retain the compatibility fixes from the original 1.97.1 upgrade and use fixed-size chunks when decoding cached issuer schema IDs to satisfy Rust 1.98 Clippy without changing the byte format. Cargo dependencies and
Cargo.lockare unchanged.Validation
cargo +1.98.1 fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningsgit diff --check504responses while fetching pinned World ID circuit artifacts; leave the test suite, cross-target builds, foreign bindings, and nightly docs to CI.Cargo reports the existing future-incompatibility warning in
proc-macro-error22.0.1.Rollout dependency
Keep this PR in draft until Infrastructure #48339, Bedrock #437, Oxide #1190, Biometric Engines #648, and Flamingo #104 are ready. Version alignment will intentionally fail while the organization variable remains 1.94.1. No live variable or infrastructure change is made here.
AI usage/prompt(s)
Codex: “Adjust the coordinated Rust upgrade PRs to align on Rust 1.98.1, validate compatibility, and include Flamingo now that it participates in organization version alignment.”
Note
Low Risk
Mostly toolchain and CI pinning with trivial Clippy-only code tweaks; no dependency or MSRV policy changes in Cargo manifests.
Overview
Pins WalletKit’s development and CI compiler to Rust 1.98.1 by updating
rust-toolchain.toml, refreshing the Nixrust-overlayinflake.lock, and setting 1.98.1 across CI, crate release, and Swift FFI release workflows (including a pinneddtolnay/rust-toolchainaction on release instead of@stable).The test job now runs on a Rust matrix that includes 1.98.1 alongside stable, nightly, and the existing 1.94.1 MSRV check; job names and
RUSTUP_TOOLCHAINreflect the matrix entry. Workspacerust-version/ Cargo.lock are unchanged—only the pinned toolchain used for builds and lint moves forward.Two small Rust 1.98 Clippy fixes: activity cache decoding uses
as_chunks::<8>()when parsing issuer schema ID blobs (same byte layout), and a World ID test usesassert_ne!instead of inequality inassert!.Reviewed by Cursor Bugbot for commit 65fd487. Bugbot is set up for automated code reviews on this repo. Configure here.