Skip to content

chore: align Rust toolchains on 1.98.1 - #509

Merged
paolodamico merged 4 commits into
mainfrom
codex/rust-1-97-rollout
Sep 17, 2026
Merged

paolodamico merged 4 commits into
mainfrom
codex/rust-1-97-rollout

Conversation

@Dzejkop

@Dzejkop Dzejkop commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Pin WalletKit's development, CI, crate release, and Swift release compilers to Rust 1.98.1 for the shared Rust rollout. Refresh only the Nix Rust overlay so the host, WASM, and Android shells resolve this release. Preserve the declared Rust 1.91 workspace MSRV.

Retain the compatibility fixes from the original 1.97.1 upgrade and use fixed-size chunks when decoding cached issuer schema IDs to satisfy Rust 1.98 Clippy without changing the byte format. Cargo dependencies and Cargo.lock are unchanged.

Validation

  • cargo +1.98.1 fmt --all -- --check
  • In the repository Nix environment: cargo clippy --workspace --all-targets --all-features -- -D warnings
  • git diff --check
  • A targeted activity-cache test build reached project compilation but was blocked by repeated GitHub 504 responses while fetching pinned World ID circuit artifacts; leave the test suite, cross-target builds, foreign bindings, and nightly docs to CI.

Cargo reports the existing future-incompatibility warning in proc-macro-error2 2.0.1.

Rollout dependency

Keep this PR in draft until Infrastructure #48339, Bedrock #437, Oxide #1190, Biometric Engines #648, and Flamingo #104 are ready. Version alignment will intentionally fail while the organization variable remains 1.94.1. No live variable or infrastructure change is made here.

AI usage/prompt(s)

Codex: “Adjust the coordinated Rust upgrade PRs to align on Rust 1.98.1, validate compatibility, and include Flamingo now that it participates in organization version alignment.”


Note

Low Risk
Mostly toolchain and CI pinning with trivial Clippy-only code tweaks; no dependency or MSRV policy changes in Cargo manifests.

Overview
Pins WalletKit’s development and CI compiler to Rust 1.98.1 by updating rust-toolchain.toml, refreshing the Nix rust-overlay in flake.lock, and setting 1.98.1 across CI, crate release, and Swift FFI release workflows (including a pinned dtolnay/rust-toolchain action on release instead of @stable).

The test job now runs on a Rust matrix that includes 1.98.1 alongside stable, nightly, and the existing 1.94.1 MSRV check; job names and RUSTUP_TOOLCHAIN reflect the matrix entry. Workspace rust-version / Cargo.lock are unchanged—only the pinned toolchain used for builds and lint moves forward.

Two small Rust 1.98 Clippy fixes: activity cache decoding uses as_chunks::<8>() when parsing issuer schema ID blobs (same byte layout), and a World ID test uses assert_ne! instead of inequality in assert!.

Reviewed by Cursor Bugbot for commit 65fd487. Bugbot is set up for automated code reviews on this repo. Configure here.

@Dzejkop Dzejkop changed the title chore: align Rust toolchains on 1.97.1 chore: align Rust toolchains on 1.98.1 Sep 7, 2026
@Dzejkop
Dzejkop marked this pull request as ready for review September 16, 2026 11:09
Dzejkop added a commit that referenced this pull request Sep 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 39198e9. Configure here.

Comment thread Cargo.toml Outdated
readme = "./README.md"
homepage = "https://docs.world.org" # TODO: Update to specific WalletKit page
rust-version = "1.91" # MSRV
rust-version = "1.94.1" # MSRV

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSRV raised despite 1.91 policy

Medium Severity

rust-version and the CI MSRV matrix now declare 1.94.1, which raises the published workspace minimum above the 1.91 MSRV this change set out to keep. Downstream crates on Rust 1.91 through 1.94.0 will fail the Cargo version check.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 39198e9. Configure here.

Dzejkop added a commit that referenced this pull request Sep 16, 2026
@Dzejkop
Dzejkop force-pushed the codex/rust-1-97-rollout branch from 8a5ba2a to 65fd487 Compare September 17, 2026 09:44
@paolodamico
paolodamico merged commit 2f381ab into main Sep 17, 2026
24 checks passed
@paolodamico
paolodamico deleted the codex/rust-1-97-rollout branch September 17, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants