Repository navigation
Document optional mapper installation requirements - #304
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56cbfe7fef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ
|
That job deletes No fix exists yet. Two options for a separate PR:
Generated by Claude Code |
strobealign 0.18.0 gives slightly different mean coverages in test_sharded_contig_input_reads_strobealign, which failed the unlocked (optimistic) CI job. Accept either the pre-0.18 or 0.18 output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ
Summary
Addresses #303: makes it clear that the bioconda package installs only the default mappers, so the others must be installed separately. Also fixes a strobealign 0.18 test failure in the unlocked CI job.
Key Changes
bioconda_mappers_note()is added to the-p/--mapperhelp ofgenome,contig,makeandmakedb. The HTML indocs/will pick it up at the next release.test_sharded_contig_input_reads_strobealignnow accepts either the pre-0.18 or the strobealign 0.18.0 output. 0.18.0 gives slightly different mean coverages, which failed thetest_dependencies_optimisticjob.Bioconda recipe check
The current recipe (0.8.0) already includes the default mappers: strobealign (default for
genome/contig), minimap2 (default formakedb) and bwa. It also has skani, the default dereplication precluster method. No change is needed.🤖 Generated with Claude Code
https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ