Skip to content

Document optional mapper installation requirements - #304

Merged
wwood merged 3 commits into
mainfrom
claude/dreamy-hamilton-72tbqh
Sep 23, 2026
Merged

wwood merged 3 commits into
mainfrom
claude/dreamy-hamilton-72tbqh

Conversation

@wwood

@wwood wwood commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Addresses #303: makes it clear that the bioconda package installs only the default mappers, so the others must be installed separately. Also fixes a strobealign 0.18 test failure in the unlocked CI job.

Key Changes

  • README.md:
    • The bioconda section now lists what the package includes: strobealign, minimap2, bwa, samtools, skani and FastANI. It explains how to install the optional mappers (bwa-mem2, minibwa, rammap) separately.
    • The dependencies list marks strobealign as the default mapper and adds bwa and minibwa. A note says which mappers bioconda installs.
  • src/cli.rs: a shared bioconda_mappers_note() is added to the -p/--mapper help of genome, contig, make and makedb. The HTML in docs/ will pick it up at the next release.
  • tests/test_cmdline.rs: test_sharded_contig_input_reads_strobealign now accepts either the pre-0.18 or the strobealign 0.18.0 output. 0.18.0 gives slightly different mean coverages, which failed the test_dependencies_optimistic job.

Bioconda recipe check

The current recipe (0.8.0) already includes the default mappers: strobealign (default for genome/contig), minimap2 (default for makedb) and bwa. It also has skani, the default dereplication precluster method. No change is needed.

🤖 Generated with Claude Code

https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56cbfe7fef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/cli.rs Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ

wwood commented Sep 22, 2026

Copy link
Copy Markdown
Owner Author

Pixi test_dependencies_optimistic (3.11, ubuntu-latest) is failing for a reason that isn't this PR's.

That job deletes pixi.lock before installing, so it picked up strobealign 0.18.0; the lockfile pins 0.17.0. tests::test_sharded_contig_input_reads_strobealign then gets slightly different mean coverages, e.g. genome3~random_sequence_length_11001 0.11057869 → 0.110588886. This PR only changes help text and the README. The locked jobs pass, and so does pixi run cargo test locally. main would fail this job the same way now.

No fix exists yet. Two options for a separate PR:

  1. Update the expected values in tests/test_cmdline.rs (test_sharded_contig_input_reads_strobealign) to the 0.18.0 output and bump strobealign in pixi.lock; or
  2. Cap strobealign = ">=0.14.0,<0.18" in pixi.toml until the test is updated.

Generated by Claude Code

strobealign 0.18.0 gives slightly different mean coverages in
test_sharded_contig_input_reads_strobealign, which failed the unlocked
(optimistic) CI job. Accept either the pre-0.18 or 0.18 output.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011bFQk8BPxzNCS67jkdFGRQ
@wwood
wwood merged commit 31147ec into main Sep 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants