Skip to content

TPSA tracking - #836

Closed
szymonlopaciuk wants to merge 97 commits into
xsuite:mainfrom
szymonlopaciuk:tpsa
Closed

TPSA tracking#836
szymonlopaciuk wants to merge 97 commits into
xsuite:mainfrom
szymonlopaciuk:tpsa

Conversation

@szymonlopaciuk

@szymonlopaciuk szymonlopaciuk commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

babreufig and others added 26 commits July 24, 2026 15:53
@babreufig @szymonlopaciuk
Extended TPSA interface, can use multi-element monitor
4ce4cbb
@babreufig @szymonlopaciuk
Implemented TPSA Bridge for tracking
b3f3b0d
@babreufig @szymonlopaciuk
Added optics calculation
0160fa8
@babreufig @szymonlopaciuk
Per-element knob compilation
8d4761e
@babreufig @szymonlopaciuk
Starting point for divergence for parametric TPSA
183a801
@babreufig @szymonlopaciuk
Implemented match for this route
9cc53be
@babreufig @szymonlopaciuk
Groundwork done for third flavor approach
d42722c
@babreufig @szymonlopaciuk
Merged matching part in
a27096f
@babreufig @szymonlopaciuk
Removed unnecessary stuff
6af649f
@babreufig @szymonlopaciuk
Refactored towards making gtpsa_lib standalone
de53d81
@babreufig @szymonlopaciuk
Refactor such that get_k1 (and other functions) are now compiled acco…
c6ccaa1 
…rdingly, so fixed-size slot array not used anymore
@szymonlopaciuk
Restore TPSA match integration after rebase
79a25fb
@szymonlopaciuk
Fixes for clang
2292c1b
@szymonlopaciuk
Basic fixes for the new xgtpsa package
b7356d0
@szymonlopaciuk
Align API with Xgtpsa
a8a1dfc
@szymonlopaciuk
add transformations to bridge for a faithful benchmark
2cbb170
@szymonlopaciuk
Experiment with a union field
f4c2ce1
@szymonlopaciuk
first integrated solution
651be8a
@szymonlopaciuk
attempt 2
6836200
@szymonlopaciuk
tests passing now
eea577d
@szymonlopaciuk
Merge branch 'main' into tpsa
35faf5a
@szymonlopaciuk
Preload dynamic libraries if needed for prebuilt kernels
8159bf1
@szymonlopaciuk
cleanup
026826d
@szymonlopaciuk
Track normal particles on a tpsa line seamlessly (truncating)
cd95f3a
@szymonlopaciuk
Use descriptors instead of __getattribute__ on BeamElement for TPSA
032d275
@szymonlopaciuk
Remove _prebuilding_kernels and fix bug in tpsa wrap
281e2c8
szymonlopaciuk
szymonlopaciuk commented Aug 6, 2026
View reviewed changes

@szymonlopaciuk szymonlopaciuk left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed until tpsa/

Comment thread examples/tpsa/000_benchmark.py Outdated
Comment thread tests/test_tpsa.py Outdated
Comment thread tests/test_tpsa.py Outdated
Comment thread tests/test_tpsa.py Outdated
Comment thread xtrack/beam_elements/elements_src/bend.h Outdated
Comment thread xtrack/headers/track.h Outdated
Comment thread xtrack/particles/local_particle_custom_api.h Outdated
Comment thread xtrack/tpsa/__init__.py Outdated
Comment thread xtrack/base_element.py Outdated
Comment thread xtrack/base_element.py Outdated
babreufig
babreufig reviewed Aug 28, 2026
View reviewed changes
Comment thread xtrack/tpsa/_knobs.py Outdated
Comment thread xtrack/base_element.py Outdated
Comment thread xtrack/beam_elements/elements_src/track_magnet_kick.h Outdated
Comment thread xtrack/tracker.py Outdated
Comment thread xtrack/base_element.py
Comment thread xtrack/tracker.py Outdated
babreufig and others added 15 commits August 28, 2026 18:57
@babreufig
Changed interface for TPSA monomial querying, accounted for review co…
c3e8005 
…mments, added type hinting
@szymonlopaciuk
Merge pull request #19 from babreufig/szymonlopaciuk-tpsa
bc2da50 
Added monomial-querying for multi_element_monitor
@szymonlopaciuk
Implement a temporary forwarding constructor, same bend model in bench
8504418
@szymonlopaciuk
remove mistakenly pushed jsons
51dd9e2
@babreufig
Adjusted madng and xsuite element configurations
3df32ce
@szymonlopaciuk
Merge pull request #20 from babreufig/szymonlopaciuk-tpsa
6232e44 
Adjusted madng and xsuite element configurations
@szymonlopaciuk
Undo incorrect optimisation
ee1cef3
@szymonlopaciuk
Small alignments in benchmark
37fa10d
@szymonlopaciuk
Fix tpsa benchmark MAD-NG script
370e996
@szymonlopaciuk
Fixes for tests
5888b6b
@szymonlopaciuk
Add dependency on madng-tpsa
247c3a0
@szymonlopaciuk
Implement Bernardo's review comments
44a8d73
@szymonlopaciuk
Fix in test for CUDA
842b0d6
@szymonlopaciuk
formatting
d28a14a
@szymonlopaciuk
Fixes after review
9861203
giadarol
giadarol requested changes Sep 8, 2026
View reviewed changes
Comment thread xtrack/base_element.py Outdated
Comment thread xtrack/base_element.py Outdated
Comment thread xtrack/beam_elements/elements_src/track_magnet_kick.h Outdated
Comment thread xtrack/beam_elements/elements_src/track_rf.h Outdated
Comment thread xtrack/beam_elements/elements_src/track_splineboris.h Outdated
Comment thread xtrack/beam_elements/elements_src/track_srotation.h Outdated
Comment thread xtrack/beam_elements/_common.py Outdated
@szymonlopaciuk

szymonlopaciuk commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

Closing in favour of #854

@szymonlopaciuk szymonlopaciuk mentioned this pull request Sep 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giadarol giadarol giadarol requested changes
+1 more reviewer
@babreufig babreufig babreufig left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szymonlopaciuk @giadarol @babreufig