Repository navigation
Conversation
rhein1
changed the base branch from
codex/mcp-ip-address-audit-20260930
to
main
September 30, 2026 14:09
This was referenced Sep 30, 2026
rhein1
marked this pull request as ready for review
October 1, 2026 23:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 1, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a95729e8f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine-surface validation fails dependency audits because the MCP/Claude SDK lockfiles contain vulnerable transitive packages and n8n-workflow 2.39.1 pins a vulnerable Axios version. Refresh the compatible locks and qualify n8n's development fixture at 2.28.4 with its exact Zod peer. The published n8n runtime peer remains unchanged, and the development graph audits clean at every severity.
The audit launcher invokes Node directly when npm_execpath is available, fixing Windows installs whose Node path contains spaces. Audit thresholds and rejection behavior are unchanged.
A separate maintenance commit records the October 1 review of the expired MatrAIx inventory hold. Its offline source lock, deterministic fixture replay, 20 unit tests and fail-closed live gate pass. Live provider and independent external compatibility evidence are still absent, so it remains unpublished_alpha with all publication/compatibility/authority flags false. The next review is due October 8. No public catalog promotion or expiry-check bypass is included.
Includes and supersedes the dependency repairs from #444, retaining those fixes together with the qualified n8n fixture. The scope is dependency qualification, the Windows audit launcher, the bounded inventory review and the hosted MCP artifact closure repair.
Local validation: n8n clean install, 8/8 tests, lint, build and audit:dev pass; MatrAIx 20/20 tests, source-lock check, expected fixture replay and live-execution denial pass; machine-surface validation and integration counts pass. Rename-preflight content matches committed blobs and its check passes with canonical LF output; a CRLF checkout produces a pre-existing false stale result.
Hosted checks on a1283ee: 48 successful, 0 pending, 0 failed at this update. Required independent approval remains outstanding. No OpenShell/RRSI worker activation, paid execution, publication or deployment is included.
The shared hosted MCP repair updates its actual lock and embedded fast-uri implementation to 3.1.8, refreshes ip-address to 10.7.3, and regenerates integrity records and notices. A regression now rejects a lock that disagrees with the advertised, installed and attested dependency. All 16 hosted artifact tests, source/artifact verification, packaging and zero-vulnerability audits pass locally. The bundle remains private and publication-disabled.