Repository navigation
feat(helm): bundle optional NVMe prerequisites - #137
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 26, 2026
Contributor
Author
|
/azp run dacs-pullrequest |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
jmclong (jmclong)
marked this pull request as ready for review
October 28, 2026 17:29
jmclong (jmclong)
requested review from
a team,
Aditya Bansal (adityabansal),
Bhargav Gulavani (bhargav-gulavani) and
Simon Croome (croomes)
as code owners
October 28, 2026 17:29
Simon Croome (croomes)
approved these changes
Oct 28, 2026
Add optional prerequisite dependencies, rollout verification, registry settings, and DACS build and pipeline integration. Preserve standalone chart publication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4e7adc4d-b2ae-4e92-9e76-2d857187198d
jmclong (jmclong)
force-pushed
the
feature/bundled-prerequisites
branch
2 times, most recently
from
October 28, 2026 19:08
7add25b to
6d7d30e
Compare
Copilot started work to fix failing Actions workflows on behalf of
jmclong (jmclong)
October 28, 2026 19:43
Simon Croome (croomes)
approved these changes
Oct 28, 2026
Tolerate CriticalAddonsOnly and prefer AKS system nodes without requiring a system pool. Match the controller's Linux amd64/arm64 eligibility, expose independent Job scheduling values, and cover defaults and overrides in Helm regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f5ab036a-4dfa-4f96-809f-5f4a4d7f6b54
jmclong (jmclong)
force-pushed
the
feature/bundled-prerequisites
branch
from
October 28, 2026 20:12
d012e1f to
6b42db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dacs-prereqas an optional, disabled-by-default dependency of both parent charts.CriticalAddonsOnly, require Linux amd64/arm64, and softly prefer AKS system nodes. Job tolerations and affinity are independently configurable; other taints still need matching tolerations.Main integration
Rebased onto main at
d2f8a210with two linear commits:7add25bf(bundled prerequisites and main-integration conflict resolutions) followed by6b42db5a(rollout-check Job scheduling). This incorporates the merged standalone-Cache (#138), ext4 compatibility (#136), and webhook startup-probe (#115) changes without a merge commit. The final tree is identical to the pre-rebase PR tipd012e1f3; no code or behavior changed during this history-only rebase.cache.enabled=true.Standalone development-chart publication is unchanged. Public MCR promotion is handled separately by dacs-internal PR 17719330, which publishes only the parent dacs chart and rewrites its bundled cache-setup image.
Validation
go fmt,go vet ./...,go build ./..., and focusedTestHelmregression tests passed.TestHelmregressions, including scheduling overrides. Direct rendering of the standalone prerequisite chart and both parent bundles confirmed the Job tolerations and affinity exactly match controller defaults, with no DaemonSet node selector.git diff --checkpassed.Live AKS rollout, reboot, upgrade/uninstall, Azure Pipelines server-side compilation, and MCR publication were not performed.