Repository navigation
feat(helm)!: separate Cache resources from controller releases - #138
Merged
Merged
Conversation
Provide standalone Cache fixtures, explicit pipeline application, and guarded controller uninstall. BREAKING CHANGE: cache.enabled=true is no longer supported. Migrate chart-owned Cache resources before upgrading and apply Cache manifests separately. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4e7adc4d-b2ae-4e92-9e76-2d857187198d
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 26, 2026
Contributor
Author
|
/azp run dacs-pullrequest |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
jmclong (jmclong)
marked this pull request as ready for review
October 28, 2026 17:29
jmclong (jmclong)
requested review from
a team,
Aditya Bansal (adityabansal),
Bhargav Gulavani (bhargav-gulavani) and
Simon Croome (croomes)
as code owners
October 28, 2026 17:29
Simon Croome (croomes)
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade impact
cache.enabled=trueis rejected. Migrate any existing chart-owned Cache before upgrading; removing the old template can otherwise delete that resource. Apply Cache configuration separately from the controller release.Force cleanup is cluster-wide, not limited to Caches created by the release. Removing finalizers can bypass unfinished cleanup and leave child resources behind.
Validation
go fmt,go vet,go build, and focusedTestHelmtests passed.Integration follow-up
This is an independent port, not stacked on bundled prerequisites (#137). Before combining the two, remove chart-managed Cache creation from the bundled-prerequisite CI paths, apply standalone fixtures only after prerequisite rollout succeeds, and reconcile overlapping deployment/docs changes. Preserve prerequisite/global-image regression coverage when resolving the modified/deleted Helm test file.
The independent ext4 compatibility fix is tracked in #136.