Repository navigation
Fix screen reader names for remaining top-bar controls - #4992
Merged
ChrisTitusTech merged 1 commit intoAug 19, 2026
Merged
Conversation
ThemeButton, FontScalingButton, SearchBar, and SearchBarClearButton had
no AutomationProperties.Name, so screen readers (Narrator, NVDA)
announce them as raw glyph text ("N/A", Unicode E8D3), an unnamed edit
field, and a button called "X". Completes the top-bar naming pass
started for SettingsButton and the window controls.
github-actions
Bot
added
bug
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded ChangesAccessibility labels
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR adds accessible names to four top-bar controls through a localized XAML-only change. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
2 tasks done
mewclouds
approved these changes
Aug 17, 2026
ChrisTitusTech
approved these changes
Aug 19, 2026
2 of 5 tasks
ChrisTitusTech
added a commit
that referenced
this pull request
Oct 21, 2026
The Win11 Creator wizard (#4925) was merged after the top-bar naming pass in #4992/#4993. Its glyph-only Back/Forward buttons report the Segoe MDL2 private-use character as their UI Automation name, and the ISO path box, the edition and USB combo boxes and the status log have an empty name because their visible labels are separate TextBlocks. Add AutomationProperties.Name to all six: "Previous Step" and "Next Step" for the arrows, and the visible label text for the other four. Cover them with a XAML test. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Chris Titus <contact@christitus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
PR #4944 added
AutomationProperties.NametoSettingsButtonand the window controls, but four top-bar controls were left unnamed, so screen readers (Narrator, NVDA) announce them by their raw content:\uE8D3(ironically, the accessibility button)This adds
AutomationProperties.Nameto all four, completing the top-bar naming pass. XAML-only change; verified with.\Compile.ps1 -Run+ Narrator, and the full Pester suite passes (549/549).Issue related to PR