Repository navigation
fix(builder): read an archive suite not published yet as empty - #30
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A build with
ARCHIVE_URLreads one suite per channel,<ubuntu>-<channel>. A suite exists only once something was published into it:noble-edgebefore the first build of main,jammy-stablebefore the first humble release. apt failsapt-get update --error-on=anyon the missingInRelease, so every build reading such a suite stops there, whether or not the package needs anything from it.build_pkg.shasks for each suite'sInReleasebefore setting the archive up:file:archive, leaves that suite out, with<suite> is not published yet;FATAL: <url>: <reason>.archive_build_test.sh(new):build_pkg.shinros:jazzy-ros-baseagainst a signed local archive that publishesnoble-stableonly. CI runs it on the jazzy leg of the builder job.Testing
packaging/tests/archive_build_test.sh, buildingduatic_probe_exec: 5 passed.stable, and the.debhasDepends: ros-jazzy-duatic-helper-msgs;edge stablewithnoble-edgemissing builds, and says the suite is not published yet;edgealone, with no suite published, builds without the archive and fails at bloom on the unresolved key;FATAL.main: 2 passed, 3 failed, the missing suite among them.!and means the next release is a major version bump)