Repository navigation
docs(repo): fifth whole-repo pass over the repository files (#1103) - #2158
Merged
Merged
Conversation
Stale claims: the benchmark workflow and Makefile point at the speed tables on docs/source/engines.rst; bump_version.py's docstring accounts for the release approval (#887) and drops the "no bump took more than a day" claim 1.5.0b9 disproves; CONTRIBUTING.md no longer says no linter is clean, that nothing checks isort, or that vermin fails on a 3.11 minimum; README.md says CHANGELOG.md holds the newest entry; discussion_report.py and leg_summary.py name their callers; run_unittest_leg.py no longer cites a timing table the workflow lost; _actions.py drops the 3.7 legs. Timed context and counts: "now that", "yet", "moves to from", "three nested limits", "in two/three forms" and similar, reworded. Line anchors: two in-repo file:line citations in examples/generators/ now name ARP.read and PCAPNG.run. Comments and docstrings only: AST guard clean, actionlint 1.7.12 clean.
Owner
Author
|
GOOD TO GO at
|
Contributor
|
Coverage: 91.55% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
Ready to merge at
|
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testpasses, and a test case covers the change (prose only; narrow selections below)What is the purpose of your pull request?
docs— documentation onlyDescription
Part of #1103 round 5, repository-files slice, on
mainat4c3d30163. Prose and comments only.Checks
.pyfiles.mainand adds none.Stale or false claims fixed
benchmark.ymlandMakefile: the speed tables are indocs/source/engines.rstand are hand-updated, so the "no longer goes stale" claim is gone.bump_version.py: a human approval sits between the bump and the release (ci(release): one approval for the whole release, not four separate environment gates #887). 1.5.0b9's release was approved three days after its bump (fix(ci): Create Release tags main's tip at approval time, not the commit it was created for #1634).CONTRIBUTING.md:test_isort_clean.pychecks isort;README.md:CHANGELOG.mdholds the newest entry only.util:_actions.pyno longer mentions 3.7;discussion_report.pyandleg_summary.pyare complete;run_unittest_leg.pyno longer cites a table that was removed.examples/benchmark/README.md: the matrix includes 3.15.experimental.yml: win-64 is published.Rule fixes
file:lineanchors now nameARP.readandPCAPNG.run.Tests:
tests/project/test_docs_*plus the conventions test, 94 passed. The 77tests/projectmodules that read the changed files, 1565 passed.