Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on Run ACP contract tests on supported Python and operating systems (#139). ACP clients can supply stdio/HTTP/SSE MCP servers per session. The adapter combines them with configured servers, discovers tools before accepting the session, and keeps provider selection in request context instead of mutating shared ToolManager state. Async workers inherit the scoped provider; normal tool permission checks remain intact. Client env values stay literal, credentials stay out of persisted session metadata, and close releases provider resources. Load/resume require clients to resend server credentials/configuration.
The ACP extra pins the existing MCP integration to SDK 1.x; MCP 2.x removed APIs this repository uses. Migrating the whole integration to 2.x is separate.
Validation: aggregate ACP plus existing MCP suite passed 79 tests before one additional isolation/permission test, which also passed in the final 3-test MCP subset. Actual local MCP stdio servers demonstrated separate environments for two sessions, literal dollar-prefixed values, tool execution through ToolManager, and cleanup. Additional test verifies simultaneous context isolation and that denial prevents execution. Scoped Ruff and diff checks pass; ACP CI includes the new tests. HTTP/SSE use existing manager paths; no live remote endpoint test is claimed.