Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 28, 2026
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on Scope client-provided MCP servers to ACP sessions (#140). Adds configured model selection through ACP session options using Penguin's request-scoped runtime factory, without changing global defaults or another session. Build/Plan modes propagate through trusted execution context; Plan is offered only while permission enforcement is enabled. Mode/model choices persist on resume. Read-only /status and /mcp commands are advertised and handled locally.
Provider credentials remain in existing Penguin configuration; this does not advertise interactive ACP authentication, arbitrary endpoint setup, or reasoning controls without a supported runtime path. Model selection failures preserve the current configuration.
Validation: 77 tests passed across aggregate ACP, existing model runtime, and model facade suites. Tests verify per-session model overrides, persisted selection, unknown model rejection, real write denial in Plan mode, and actual subprocess configuration wire calls. Scoped Ruff and diff checks pass. No real-editor/provider smoke is claimed.