Skip to content

Add session-scoped model and mode controls to ACP - #141

Closed
Maximooch wants to merge 2 commits into
feat/acp-session-mcpfrom
feat/acp-session-controls
Closed

Maximooch wants to merge 2 commits into
feat/acp-session-mcpfrom
feat/acp-session-controls

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Stacked on Scope client-provided MCP servers to ACP sessions (#140). Adds configured model selection through ACP session options using Penguin's request-scoped runtime factory, without changing global defaults or another session. Build/Plan modes propagate through trusted execution context; Plan is offered only while permission enforcement is enabled. Mode/model choices persist on resume. Read-only /status and /mcp commands are advertised and handled locally.

Provider credentials remain in existing Penguin configuration; this does not advertise interactive ACP authentication, arbitrary endpoint setup, or reasoning controls without a supported runtime path. Model selection failures preserve the current configuration.

Validation: 77 tests passed across aggregate ACP, existing model runtime, and model facade suites. Tests verify per-session model overrides, persisted selection, unknown model rejection, real write denial in Plan mode, and actual subprocess configuration wire calls. Scoped Ruff and diff checks pass. No real-editor/provider smoke is claimed.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:25am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 599439d8 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant