Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 28, 2026
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on BOTH the ACP controls stack (#141) and process/subagent reliability (#133). The base branch stack/acp-runtime-base is an integration branch containing those reviewed foundations; no PR was merged. Retarget after those prerequisites land.
Adds opt-in presentation for the current draft ACP subagent RFD using clientCapabilities.subagents. Runtime-observed child ownership produces ordered associations, directed message records, child tools/public output, and work-state updates. Background children with independent tasks can be cancelled without cancelling the parent; foreground children sharing the parent's task advertise no independent cancel. Reload preserves nested parentage, removes historical cancel authority, and reports unconfirmed activity honestly. Without negotiation, activity appears as ordinary parent tool cards. No v2 or older AIR-specific compatibility claim.
A small NDJSON transport preserves the canonical draft capability before the SDK strips unknown fields; JSON-RPC dispatch remains in the official SDK. It also handles malformed JSON/blank frames without corrupting protocol output. Persisted child notifications use scoped replay envelopes. Native store lookups now preserve the active session pointer, avoiding background-child journal writes contaminating another request.
Validation: 46 aggregate ACP tests passed before two added regressions; final 8 child/control tests pass (nested replay/store isolation, background cancel, Plan reload with enforcement disabled, busy controls). Existing lifecycle/executor/reliability tests: 93 passed, 4 skipped, 1 deselected. Raw stdio tests exercise negotiated and legacy clients with the actual runtime lifecycle producer and deterministic core/scope fixtures. Scoped Ruff and diff checks pass. No GUI-editor/live-provider smoke is claimed. Background terminal panels, native full-file diffs, interactive ACP auth and goal extensions remain separate.