Skip to content

Integrate the verified ACP baseline and reliability stack - #161

Merged
Maximooch merged 58 commits into
mainfrom
integration/acp-baseline
Oct 28, 2026
Merged

Maximooch merged 58 commits into
mainfrom
integration/acp-baseline

Conversation

@Maximooch

@Maximooch Maximooch commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

This integration preserves the commit history of all 25 ACP drafts and three reliability prerequisites (#133–#160), then closes baseline gaps found with a live ChatGPT-backed model. The primary checkout is untouched.

Live gpt-6.1-sol checks through Penguin's existing OAuth login passed: MCP discovery/invocation, native file read/write with approval, a rejected write leaving the preexisting canary unchanged with no alternative tool attempt, PNG plus embedded context, close/load and fresh-process recall, cancellation, and two isolated parallel writes with separate response streams. The shipped CLI now activates only its configured provider's saved login; no Codex/Minecraft credentials are imported.

Live-found fixes included here:

  • Wire configured approval/path rules and security mode into the actual policy; validate before publishing the enforcer.
  • Include negotiated MCP tools in the default model tool payload while preserving explicit allowlists.
  • Preserve explicit vision support when rebuilding startup model configuration.
  • Activate the selected provider's existing saved credentials for ACP startup.
  • Recover from taskkill/WMI failure using native owned-tree cleanup, with PID-reuse checks and a forced-failure Windows regression. This remains snapshot-based, not Job Object containment.

Validation: all 306 selected tests passed on final integration head 7f855cc85b8c071d79bdf641dbb67aeed8a828ad, including native Windows processes, storage, ACP wire contracts, permissions, startup, messaging, and default-runtime regressions. All executed pull-request CI checks passed, including the four Windows/Linux ACP jobs across Python 3.11 and 3.12. Merged as abd8a663a073fae77ec35154ef8f9fbcb1a1e14f; its tree is identical to the tested head. Post-merge CI is rerunning normally.

No purchase or new subscription was made. Documented optional-feature and recovery limits remain in context/tasks/acp.md and docs/ACP.md. Permission enforcement is an application policy, not an OS sandbox. Parallel root runtimes remain opt-in; live child processes are not recovered after adapter death.

@Maximooch
Maximooch marked this pull request as ready for review October 28, 2026 22:23
@Maximooch
Maximooch merged commit abd8a66 into main Oct 28, 2026
23 checks passed
This was referenced Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 7f855cc8 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant